Review main Merged

50256Revert "[BUGFIX] Do not render HTML in Install Tool's flash message"

Stefan Neufeind CR +2 V +2 Easy +1 −1 updated 10/18/16, 09:30

Commit message

Some places intentionally use HTML which needs to be passed though in
raw. Patch needs more work.

This reverts commit 2cead56b6ffe5ebb0d8dd8308d0155beaa0fc08f.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Stefan Neufeind uploaded patch set 1 10/18/16, 09:02

  2. Stefan Neufeind commented on patch set 1 CR +1 10/18/16, 09:03

    At least in "TCA Migrations" HTML seems to be used for the status-message (for an ordered list). So at least there raw html is needed. Let's check this in more detail first ...
  3. TYPO3com voted on patch set 1 V +1 10/18/16, 09:06 Completed build in 04m 13s on Tue, 18 Oct, 11:06 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3870

  4. Frank Nägler commented on patch set 1 CR -1 10/18/16, 09:07

    please set the issue numbers and relation as described here: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/GeneralTopics/LifeOfAPatch.html?highlight=revert#reverting-patches In general I opt for revert if we have a problem here, because the release is planned in some hours.
  5. Stefan Neufeind updated the commit message in patch set 2 10/18/16, 09:10

  6. TYPO3com voted on patch set 2 V +1 10/18/16, 09:15 Completed build in 04m 07s on Tue, 18 Oct, 11:15 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3871

  7. Benni Mack voted on patch set 2 CR +2 V +2 10/18/16, 09:30

  8. Gerrit merged patch set 2 10/18/16, 09:30