Review main Merged

50263[FEATURE] Allow setting a default replyTo-email-address

Stefan Neufeind CR +2 V +2 Normal +122 −8 updated 02/10/18, 23:04

Commit message

If no other email-address is set as reply-to use this address
as default. This is similar to the existing defaultMailFromAddress.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 5172

Show 3547 earlier messages
  1. Stefan Neufeind uploaded patch set 1 10/18/16, 13:32

  2. Stefan Neufeind commented on patch set 1 10/18/16, 13:32

    some code for discussion (so far untested)
  3. Stefan Neufeind commented on patch set 1 10/18/16, 13:33

    needs an RST
  4. TYPO3com voted on patch set 1 V -1 10/18/16, 13:37 Completed build in 05m 36s on Tue, 18 Oct, 03:37 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3888

  5. Stefan Neufeind uploaded patch set 2 10/18/16, 13:44

  6. Stefan Neufeind commented on patch set 1 10/18/16, 13:46

    CGL-check complained about the trailing comma in DefaultConfiguration.php. But could it be that comma is needed in order for the install-tool to show the field-comment correctly? (which would be a separate issue then)
  7. TYPO3com voted on patch set 2 V -1 10/18/16, 13:50 Completed build in 05m 48s on Tue, 18 Oct, 03:50 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3889

  8. Stefan Neufeind commented on patch set 1 10/18/16, 13:58

    separate issue for the trailing-comma-thing: https://review.typo3.org/50265
  9. Stefan Neufeind uploaded patch set 3 10/31/16, 23:27

  10. Stefan Neufeind commented on patch set 3 10/31/16, 23:28

    Since 50265 is merged, here is a version without trailing comma in DefaultConfiguration.php for the newly added option.
  11. TYPO3com voted on patch set 3 V +1 10/31/16, 23:32 Completed build in 04m 52s on Tue, 1 Nov, 12:32 AM Test Summary: 54803 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4518

  12. Josef Glatz commented on patch set 3 11/02/16, 12:32

    DefaultConfiguration.php:1151

    Is there a reason why setting the name is not an specific configoption like "defaultMailFromName"?
  13. Stefan Neufeind commented on patch set 3 11/02/16, 12:35

    DefaultConfiguration.php:1151 Reply

    Only reason is the swiftmailer-API. It has name/email separate but not for replyTo. We could however add separate values here and combine them ourselves when dealing with the API - to have our config independent of some other API. Makes sense? Then I'll adjust that ...
  14. Josef Glatz commented on patch set 3 11/03/16, 05:47

    hmm. I thought about this and I would go with just one config option. Because dealing with multiple addresses and separated name/email fields is also annoying.
  15. Josef Glatz commented on patch set 3 01/09/17, 06:19

    Hey Stefan, is this still in WIP?
  16. Stefan Neufeind commented on patch set 3 01/09/17, 06:39

    I expect it should work. Needs a decision if we want to keep it as is (one field instead of two), needs testing and an rst-file.
  17. Benni Mack commented on patch set 3 04/21/17, 14:10

    Why is still WIP? Easy feature, why not finishing it? replyTo syntax should be 1:1 as you can do in switfmailer, can be array etc.
  18. Stefan Neufeind commented on patch set 3 04/21/17, 14:16

    imho we lacked a decision if it should be the same as from (separate fields for name and address) or one setting like we have in the api of swiftmailer. Both makes kind of sense imho. For using multiple addresses etc. maybe having just one setting would be easier. Does a decision here imply any change to the from-setting as well (as a separate and breaking change)?
  19. Benni Mack commented on patch set 3 04/21/17, 14:31

    a) introduce the new setting with the same syntax as swiftmailer (within this patch) b) separate patch to migrate the old settings into the new format, should be really simple with the SilentUpgrader.
  20. Oliver Klee commented on patch set 3 04/21/17, 14:57

    MailUtility.php:125

    Can we please have return types for all new methods?
  21. Andreas Wolf uploaded patch set 4 11/30/17, 17:22

  22. TYPO3com voted on patch set 4 V -1 11/30/17, 17:22 Completed build in 12s on Thu, 30 Nov, 06:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17125

  23. Andreas Wolf uploaded patch set 5 11/30/17, 18:17

  24. TYPO3com voted on patch set 5 V +1 11/30/17, 18:27 Completed build in 10m 34s on Thu, 30 Nov, 07:27 PM Test Summary: 57060 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17127

  25. Stefan Neufeind uploaded patch set 6 12/01/17, 08:22

  26. Stefan Neufeind commented on patch set 6 12/01/17, 08:24

    @Andreas: Thanks for taking care. Indeed separate params for Address/Name exist there as well. Might have been different in the past? Or I overlooked something - anyway. I've added the separate fields in DefaultConfiguration.php as well now.
  27. Stefan Neufeind commented on patch set 6 12/01/17, 08:27

    !!! Now I recall why the idea was there to have one field and not address/name separate: To be able to specify multiple addresses. For From that's not needed, but for To/ReplyTo it might make sense. Decision on that? Different solution?
  28. TYPO3com voted on patch set 6 V -1 12/01/17, 08:48 Completed build in 25m 42s on Fri, 1 Dec, 09:48 AM Test Summary: 57059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17149

  29. TYPO3com voted on patch set 6 V +1 12/01/17, 10:42 Completed build in 2h 45m 17s on Fri, 1 Dec, 11:42 AM Test Summary: 57060 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17149

  30. Oliver Klee commented on patch set 5 12/01/17, 11:09

    MailUtility.php:122

    array|null
  31. Jörg Bösche uploaded patch set 7 12/04/17, 07:49

  32. TYPO3com voted on patch set 7 V -1 12/04/17, 07:49 Completed build in 05s on Mon, 4 Dec, 08:49 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-1876

  33. TYPO3com voted on patch set 7 V +1 12/04/17, 07:59 Completed build in 09m 52s on Mon, 4 Dec, 08:59 AM Test Summary: 57096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17186

  34. Andreas Wolf uploaded patch set 8 12/22/17, 14:04

  35. TYPO3com voted on patch set 8 V +1 12/22/17, 14:14 Completed build in 09m 00s on Fri, 22 Dec, 03:14 PM Test Summary: 29987 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17941

  36. Oliver Klee commented on patch set 8 12/22/17, 15:24

    DefaultConfiguration.php:1062

    Let's have a trailing comma after the last element, too. (This will keep the line unchanged when we add more lines.)

    MailUtilityTest.php:130

    @return

    MailUtilityTest.php:140

    We should also have tests for the cases where no address is set.

    MailUtilityTest.php:148

    @param

    MailUtilityTest.php:152

    Why not assertSame?
  37. Helmut Hummel commented on patch set 8 12/24/17, 12:51

    DefaultConfiguration.php:1062 Reply

    big +1 here. we should even add a php-cs-fixer rule for that
  38. Reiner Teubner uploaded patch set 9 01/05/18, 11:55

  39. Reiner Teubner commented on patch set 9 01/05/18, 11:57

    ContentObjectRenderer.php:5970 Unresolved

    check missing for empty system reply address
  40. TYPO3com voted on patch set 9 V +1 01/05/18, 12:04 Completed build in 08m 13s on Fri, 5 Jan, 01:04 PM Test Summary: 30017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18110

  41. Stefan Neufeind commented on patch set 9 01/05/18, 12:20

    Should we do a parseAddresses on the systemReplyTo-addresses as well so it's possible to also specify multiple addresses there? But then we'd have one field (and not two) which would be parsed and which could potentially also contain multiple addresses and ... *sigh*
  42. Anja Leichsenring commented on patch set 9 01/05/18, 15:15

    > Patch Set 9: > > Should we do a parseAddresses on the systemReplyTo-addresses as well so it's possible to also specify multiple addresses there? But then we'd have one field (and not two) which would be parsed and which could potentially also contain multiple addresses and ... *sigh* IMO it makes no sense to have multiple replyTo addresses set. Usually it is one and this is it. If someone really needs more, they can always extend the function on their own.
  43. Anja Leichsenring voted on patch set 9 V +1 CR +1 01/05/18, 15:15

  44. Reiner Teubner uploaded patch set 10 01/05/18, 15:16

  45. Reiner Teubner voted on patch set 10 V +1 CR +1 01/05/18, 15:16

  46. Anja Leichsenring voted on patch set 10 V +1 CR +1 01/05/18, 15:19

  47. TYPO3com voted on patch set 10 V +1 01/05/18, 15:25 Completed build in 09m 03s on Fri, 5 Jan, 04:25 PM Test Summary: 30017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18123

  1. Jigal van Hemert voted on patch set 10 V +2 CR +2 01/06/18, 09:40

  2. Jigal van Hemert commented on patch set 10 V 0 CR -1 01/06/18, 09:43

    Feature, so needs an rst
  3. Jigal van Hemert uploaded patch set 11 01/06/18, 10:21

  4. Jigal van Hemert voted on patch set 11 V +2 CR +2 01/06/18, 10:22

  5. TYPO3com voted on patch set 11 V +1 01/06/18, 10:27 Completed build in 06m 26s on Sat, 6 Jan, 11:27 AM Test Summary: 30017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18126

  6. Stefan Neufeind commented on patch set 11 V -1 01/06/18, 14:40

    I assumed that sending email to through "emailMeAtLogin" would use sendNotifyEmail(). But mails sent upon login don't have a replyTo set. It uses MailMessage. So imho we should add the systemReplyTo there and only override it in MailMessage if a different one is specified.
  7. Anja Leichsenring commented on patch set 11 01/18/18, 21:13

    > Patch Set 11: Verified-1 > > I assumed that sending email to through "emailMeAtLogin" would use sendNotifyEmail(). But mails sent upon login don't have a replyTo set. It uses MailMessage. So imho we should add the systemReplyTo there and only override it in MailMessage if a different one is specified. Now you blocked your own patch. How do we proceed here?
  8. Jigal van Hemert uploaded patch set 12 01/19/18, 09:57

  9. TYPO3com voted on patch set 12 V +1 01/19/18, 10:04 Completed build in 06m 30s on Fri, 19 Jan, 11:04 AM Test Summary: 30193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18451

  10. Mathias Schreiber uploaded patch set 13 02/05/18, 19:00

  11. TYPO3com voted on patch set 13 V +1 02/05/18, 19:06 Completed build in 06m 23s on Mon, 5 Feb, 08:06 PM Test Summary: 30428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18953

  12. Benni Mack commented on patch set 13 02/06/18, 20:24

    MailMessage.php:67

    do we need to check if the getSytemReplyTo() !== [] as well?
  13. Benni Mack uploaded patch set 14 02/10/18, 21:22

  14. Mathias Schreiber voted on patch set 14 V +1 CR +1 02/10/18, 21:23

  15. TYPO3com voted on patch set 14 V -1 02/10/18, 21:31 Completed build in 08m 52s on Sat, 10 Feb, 10:31 PM Test Summary: 4 of 30637 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19313

  16. TYPO3com commented on patch set 14 02/10/18, 21:34 Completed build in 21m 23s on Sat, 10 Feb, 10:34 PM Test Summary: 3 of 30637 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19313

  17. TYPO3com commented on patch set 14 02/10/18, 21:47 Completed build in 46m 30s on Sat, 10 Feb, 10:47 PM Test Summary: 3 of 30637 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19313

  18. TYPO3com commented on patch set 14 02/10/18, 21:56 Completed build in 1h 21m 07s on Sat, 10 Feb, 10:56 PM Test Summary: 3 of 30637 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19313

  19. TYPO3com commented on patch set 14 02/10/18, 22:08 Completed build in 2h 07m 38s on Sat, 10 Feb, 11:08 PM Test Summary: 3 of 30637 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19313

  20. Mathias Schreiber uploaded patch set 15 02/10/18, 22:11

  21. TYPO3com voted on patch set 15 V +1 02/10/18, 22:19 Completed build in 07m 58s on Sat, 10 Feb, 11:19 PM Test Summary: 30482 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19316

  22. Benni Mack voted on patch set 15 V +1 CR +1 02/10/18, 22:46

  23. Mathias Schreiber voted on patch set 15 V +1 CR +1 02/10/18, 22:47

  24. Benni Mack voted on patch set 15 V +2 CR +2 02/10/18, 23:04

  25. Benni Mack merged patch set 16 02/10/18, 23:04