Review main Merged

50265[BUGFIX] Fetching configuration-comments should require no comma

Stefan Neufeind CR +2 V +2 Easy +10 −13 updated 10/24/16, 13:22

Commit message

So far a comma was required before the comment. But CGL says that
the last element in an array should have no trailing comma.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Stefan Neufeind uploaded patch set 1 10/18/16, 13:57

  2. Stefan Neufeind commented on patch set 1 10/18/16, 13:58

    Can we assume the regex is okay even not checking for the comma? Seems to work so far imho.
  3. TYPO3com voted on patch set 1 V +1 10/18/16, 14:03 Completed build in 05m 34s on Tue, 18 Oct, 04:03 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3891

  4. Markus Klein commented on patch set 2 10/21/16, 08:32

    Published edit on patch set 1.
  5. Markus Klein voted on patch set 2 CR +1 V +1 10/21/16, 08:35

  6. TYPO3com voted on patch set 2 V -1 10/21/16, 08:45 Completed build in 13m 29s on Fri, 21 Oct, 10:45 AM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3965

  7. Markus Klein commented on patch set 3 10/21/16, 10:01

    Published edit on patch set 2.
  8. Markus Klein commented on patch set 3 CR +1 V +1 10/21/16, 10:01

    Weird. Set 2 had a syntax error and yet it was working on my maschine....
  9. TYPO3com voted on patch set 3 V +1 10/21/16, 10:05 Completed build in 04m 45s on Fri, 21 Oct, 12:05 PM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3972

  10. Benni Mack commented on patch set 3 CR -1 10/24/16, 11:33

    does not display ANY comments anymore in the install tool.
  11. Markus Klein commented on patch set 3 CR 0 V 0 10/24/16, 12:08

    Strange... will test again.
  12. Markus Klein uploaded patch set 4 10/24/16, 12:42

  13. Markus Klein voted on patch set 4 CR +1 V +1 10/24/16, 12:43

  14. TYPO3com voted on patch set 4 V +1 10/24/16, 12:47 Completed build in 04m 32s on Mon, 24 Oct, 02:47 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4061

  15. Anja Leichsenring voted on patch set 4 CR +2 V +2 10/24/16, 13:22

  16. Gerrit merged patch set 4 10/24/16, 13:22

  17. Anja Leichsenring commented on patch set 5 10/24/16, 13:22

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 90cbdc9454914aabad5f4dbbb57ec8f1b448e2d6