Review main Merged

50281[TASK] Goodbye phantomJS, hello firefox

Christian Kuhn CR +2 V +2 Normal +8 −119 updated 10/19/16, 19:04

Commit message

phantomJS is too unstable. Base the acceptance tests on
firefox only for now, free composer from phantom installers.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 57

  1. Christian Kuhn uploaded patch set 1 10/19/16, 18:12

  2. Christian Kuhn uploaded patch set 2 10/19/16, 18:14

  3. TYPO3com voted on patch set 1 V -1 10/19/16, 18:17 Completed build in 04m 59s on Wed, 19 Oct, 08:17 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3931

  4. TYPO3com voted on patch set 2 V +1 10/19/16, 18:19 Completed build in 04m 57s on Wed, 19 Oct, 08:19 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3932

  5. Christian Kuhn commented on patch set 2 10/19/16, 18:28

    bamboo nightly is green with that patch: https://bamboo.typo3.com/browse/CORE-CB-191 I've had a couple of runs with firefox, it looks mostly stable except a slight race condition that happened on our quickest server once. we may fix that later if needed. I'll merge that patch soon to continue on the docker images that deliver a firefox version that works. And hey, this ugly 'phantom installer' is now gone, too, in composer.
  6. Christian Kuhn voted on patch set 2 CR +2 V +2 10/19/16, 19:04

  7. Gerrit merged patch set 2 10/19/16, 19:04