Review main Merged

50283[BUGFIX] Backend page module: set default mode to "Columns"

Josef Glatz CR +2 V +2 Easy +1 −1 updated 10/21/16, 13:23

Commit message

Change the page module default mode from "QuickEdit" to "Columns".
Especially for TYPO3 newcomers it's much easier to get an overview
of how to create content elements.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 1620

  1. Josef Glatz uploaded patch set 1 10/19/16, 18:49

  2. Josef Glatz commented on patch set 1 10/19/16, 18:50

    Disable QuickEdit, as a first step to outsource the annoying QuickEdit
  3. TYPO3com voted on patch set 1 V +1 10/19/16, 18:53 Completed build in 04m 18s on Wed, 19 Oct, 08:53 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3933

  4. Mathias Schreiber voted on patch set 1 CR +1 V +1 10/20/16, 06:05

  5. Christian Kuhn commented on patch set 1 10/21/16, 11:00

    i think if we just swap the order in the drop-down, the default module would probably change, too, indirectly. this way we probably wouldn't need the default ts config. maybe we should prefer that. could be worth some minutes of investigation. also, i think this patch would be worth a 7.6 backport since the quick edit module "default" is so annoying.
  6. Christian Kuhn commented on patch set 1 10/21/16, 11:01

    ah scratch that drop-down idea, that won't work.
  7. Christian Kuhn commented on patch set 1 CR -1 10/21/16, 11:04

    will review the patch.
  8. Christian Kuhn commented on patch set 1 10/21/16, 12:00

    on it.
  9. Christian Kuhn commented on patch set 1 10/21/16, 12:27

    does not work for me, test case: * create fresh new admin user * login, click on "page" -> Quickedit is selected
  10. Josef Glatz commented on patch set 1 10/21/16, 12:57

    on it
  11. Christian Kuhn uploaded patch set 2 10/21/16, 13:06

  12. Christian Kuhn updated the commit message in patch set 3 10/21/16, 13:07

  13. TYPO3com voted on patch set 2 V +1 10/21/16, 13:11 Completed build in 04m 02s on Fri, 21 Oct, 03:11 PM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3990

  14. TYPO3com voted on patch set 3 V +1 10/21/16, 13:13 Completed build in 05m 56s on Fri, 21 Oct, 03:13 PM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3991

  15. Christian Kuhn updated the commit message in patch set 4 10/21/16, 13:19

  16. Christian Kuhn voted on patch set 4 CR +1 V +1 10/21/16, 13:19

  17. Benni Mack voted on patch set 4 CR +2 V +2 10/21/16, 13:22

  18. Gerrit merged patch set 4 10/21/16, 13:22

  19. Benni Mack commented on patch set 5 10/21/16, 13:22

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit c25ab7d8b18a9a37c7e6d77bb40c3fb2fafffdb0
  20. TYPO3com commented on patch set 4 10/21/16, 13:23 Completed build in 04m 04s on Fri, 21 Oct, 03:23 PM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3992