50284[BUGFIX] Prevent malformed SQL query in AbstractDatabaseRecordList
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Markus Klein +1
- Wouter Wolters +1
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1819
-
Claus Due uploaded patch set 1 10/19/16, 21:25
-
TYPO3com voted on patch set 1 V +1 10/19/16, 21:29 Completed build in 04m 32s on Wed, 19 Oct, 11:29 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3936
-
Markus Klein voted on patch set 1 CR +1 V +1 10/20/16, 09:56
-
Wouter Wolters voted on patch set 1 CR +1 10/20/16, 09:59
-
Benni Mack commented on patch set 1 10/20/16, 10:27
-
Claus Due commented on patch set 1 10/20/16, 10:37
Trying now that this also would solve it. If no other guards are made for this, the change would indeed return all results for those two cases. -
Claus Due commented on patch set 1 10/20/16, 10:43
Tested now - returning any automatically negative match like `0=1` from the function causes the page module to not show anything at all. Any returned condition prefixed or suffixed with AND causes another type of SQL error (the condition is inserted in parenthesis). It truly does look like the migrations have changed this requirement to an empty string or something automatically true like 1=1 (in which case an empty string would be just as fine I guess). Question is: should I change this to 1=1 or do we prefer an empty string? -
Markus Klein commented on patch set 1 10/20/16, 10:48
The return comment says "if applicable" hence I prefer empty string -
Markus Klein commented on patch set 1 10/20/16, 10:49
Original change in https://review.typo3.org/48240 -
Markus Klein commented on patch set 1 CR 0 V 0 10/20/16, 10:54
To be precise: https://review.typo3.org/#/c/48948/3/typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php I added the second 1=1 thing, because the function was lacking a return statement. -
Markus Klein voted on patch set 1 CR +1 10/20/16, 10:54
-
Claus Due commented on patch set 1 10/20/16, 11:05
I also tested the behavior of the search - if you enter an empty query (which these cases seem to be for) the search dialog now closes itself and simply shows all items. All looks well! -
Christian Kuhn commented on patch set 1 CR -1 10/21/16, 10:44
on it. -
Christian Kuhn commented on patch set 1 10/21/16, 11:47
running that patch through ac tests now. -
Christian Kuhn voted on patch set 1 CR +1 V +1 10/21/16, 11:48
-
Christian Kuhn voted on patch set 1 V 0 10/21/16, 11:49
-
Christian Kuhn voted on patch set 1 V +1 10/21/16, 11:56
-
Benni Mack voted on patch set 1 CR +2 V +2 10/21/16, 12:30
-
Gerrit merged patch set 1 10/21/16, 12:30
AbstractDatabaseRecordList.php:919