Review main Merged

50291[BUGFIX] Avoid fatal errors in Admin Panel

Benni Mack CR +2 V +2 Easy +0 −18 updated 10/21/16, 13:58

Commit message

The functionality to display / explain DB select queries does not
work with DBAL and doctrine anymore.

The leftovers in admin panel caused a fatal PHP error due to a missing
method, which was now removed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Benni Mack uploaded patch set 1 10/20/16, 14:16

  2. TYPO3com voted on patch set 1 V +1 10/20/16, 14:20 Completed build in 04m 17s on Thu, 20 Oct, 04:20 PM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3953

  3. Johannes Goslar voted on patch set 1 CR +1 10/20/16, 15:13

  4. Benni Mack uploaded patch set 2 10/21/16, 13:28

  5. TYPO3com voted on patch set 2 V +1 10/21/16, 13:34 Completed build in 05m 10s on Fri, 21 Oct, 03:34 PM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3994

  6. Frank Nägler voted on patch set 2 CR +1 V +1 10/21/16, 13:37

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 10/21/16, 13:58

  8. Gerrit merged patch set 2 10/21/16, 13:58