Review main Merged

50322[BUGFIX] Fix unclear position for the new page using the wizard

Michael Oehlhof CR +2 V +2 Easy +18 −4 updated 11/29/16, 09:51

Commit message

Review

  • Code review CR +2
    • Jan Helke +2
    • Anja Leichsenring +1
  • Verified V +2
    • Jan Helke +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1520

  1. Michael Oehlhof uploaded patch set 1 10/22/16, 09:32

  2. TYPO3com voted on patch set 1 V -1 10/22/16, 09:37 Completed build in 04m 42s on Sat, 22 Oct, 11:37 AM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4011

  3. Wouter Wolters commented on patch set 1 10/22/16, 11:48

    PagePositionMap.php:232

    ===
  4. Michael Oehlhof uploaded patch set 2 10/22/16, 22:12

  5. TYPO3com voted on patch set 2 V +1 10/22/16, 22:17 Completed build in 04m 45s on Sun, 23 Oct, 12:17 AM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4023

  6. Christian Toffolo voted on patch set 2 V +1 10/23/16, 07:42

  7. Riccardo De Contardi commented on patch set 2 V -1 10/23/16, 08:22

    please see my comment and attached screenshot here https://forge.typo3.org/issues/72957#note-15
  8. Michael Oehlhof uploaded patch set 3 10/23/16, 11:53

  9. TYPO3com voted on patch set 3 V +1 10/23/16, 11:59 Completed build in 06m 05s on Sun, 23 Oct, 01:59 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4030

  10. Christian Toffolo commented on patch set 3 V -1 10/23/16, 13:22

    Unluckily there's still another small problem. If you try to create a page from a page that has no childrens, the arrow that signal the position for the sub-page of this page is not indented. http://i1356.photobucket.com/albums/q732/ian388/2016-10-23%2015_15_25-DummySite%20TYPO3%20CMS%207.6.11_zpskef8w6pt.png
  11. Michael Oehlhof uploaded patch set 4 10/26/16, 20:19

  12. TYPO3com voted on patch set 4 V +1 10/26/16, 20:23 Completed build in 03m 26s on Wed, 26 Oct, 10:23 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4278

  13. Riccardo De Contardi commented on patch set 4 10/26/16, 20:38

    The problem reported by Christian Toffolo seems still present, but not for the LAST page of the tree without childrens
  14. Anja Leichsenring updated the commit message in patch set 5 10/27/16, 08:41

  15. TYPO3com voted on patch set 5 V +1 10/27/16, 08:45 Completed build in 03m 39s on Thu, 27 Oct, 10:45 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4289

  16. Anja Leichsenring voted on patch set 5 CR +1 V +1 10/27/16, 08:45

  17. Jan Helke voted on patch set 5 CR +2 V +2 10/27/16, 09:18

  18. Gerrit merged patch set 5 10/27/16, 09:18

  19. Jan Helke commented on patch set 6 10/27/16, 09:18

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 655f3832b22624670f8c94b9c33330e322185f6e
  20. Christian Toffolo commented on patch set 6 11/29/16, 09:51

    Please see my comment on Patch Set 3. This patch still has that problem.