Review main Merged

50334[TASK] Replace setLocale() in tests with phpunit backup functionality

Anja Leichsenring CR +2 V +2 Normal +31 −112 updated 10/25/16, 14:32

Commit message

There is a phpunit shipped functionality to reliably fiddle with locale
settings and have the valid settings back afterwards.
This funcionality was not used in core unit tests yet, so it is
introduced now.

In this process, some sanitizing to prevent tests from fail due to
non existent locales on a certain system is added.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1117

  1. Anja Leichsenring uploaded patch set 1 10/24/16, 11:17

  2. Anja Leichsenring updated the commit message in patch set 2 10/24/16, 11:21

  3. Anja Leichsenring updated the commit message in patch set 3 10/24/16, 11:22

  4. TYPO3com voted on patch set 1 V -1 10/24/16, 11:24 Completed build in 07m 27s on Mon, 24 Oct, 01:24 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4049

  5. TYPO3com voted on patch set 2 V -1 10/24/16, 11:28 Completed build in 06m 21s on Mon, 24 Oct, 01:28 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4050

  6. TYPO3com voted on patch set 3 V -1 10/24/16, 11:29 Completed build in 07m 01s on Mon, 24 Oct, 01:29 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4051

  7. Anja Leichsenring uploaded patch set 4 10/24/16, 11:54

  8. TYPO3com voted on patch set 4 V +1 10/24/16, 12:00 Completed build in 05m 20s on Mon, 24 Oct, 02:00 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4057

  9. Anja Leichsenring uploaded patch set 5 10/24/16, 19:54

  10. TYPO3com voted on patch set 5 V +1 10/24/16, 19:59 Completed build in 05m 11s on Mon, 24 Oct, 09:59 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4100

  11. Wouter Wolters voted on patch set 5 CR +1 V +1 10/24/16, 20:01

  12. Anja Leichsenring uploaded patch set 6 10/24/16, 20:04

  13. TYPO3com voted on patch set 6 V +1 10/24/16, 20:11 Completed build in 06m 45s on Mon, 24 Oct, 10:11 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4101

  14. Wouter Wolters voted on patch set 6 CR +1 V +1 10/24/16, 21:14

  15. Christian Kuhn commented on patch set 6 10/25/16, 14:15

    let's see if travis will be happy with that. https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/170469371
  16. Christian Kuhn voted on patch set 6 CR +2 V +2 10/25/16, 14:32

  17. Gerrit merged patch set 6 10/25/16, 14:32