Review main Merged

50339[BUGFIX] Fix bug in Popover.setOptions and add JSUnit tests

Frank Nägler CR +2 V +2 Normal +77 −2 updated 10/24/16, 16:27

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Frank Nägler uploaded patch set 1 10/24/16, 14:01

  2. TYPO3com voted on patch set 1 V +1 10/24/16, 14:08 Completed build in 06m 09s on Mon, 24 Oct, 04:08 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4064

  3. Wouter Wolters commented on patch set 1 10/24/16, 14:09

    Popover.js:54

    .data('title')

    Popover.js:55

    .data('content')
  4. Stefan Bürk uploaded patch set 2 10/24/16, 14:20

  5. Stefan Bürk commented on patch set 2 CR +1 V +1 10/24/16, 14:22

    Changed attr to data methods like mentioned by Wouter.
  6. TYPO3com voted on patch set 2 V +1 10/24/16, 14:24 Completed build in 04m 44s on Mon, 24 Oct, 04:24 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4066

  7. Wouter Wolters voted on patch set 2 CR +1 10/24/16, 14:34

  8. Anja Leichsenring voted on patch set 2 CR +2 V +2 10/24/16, 16:27

  9. Gerrit merged patch set 2 10/24/16, 16:27