Review main Merged

50340[TASK] Add jasmine typings as dev dependency

Frank Nägler CR +2 V +2 Easy +1 −0 updated 10/24/16, 16:28

Commit message

This patch add jasmine typings as dev dependency which brings IDE
support / code completion for the testing framework.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Patricia Tiedemann +1
    • Stefan Bürk +1
  • Verified V +2
    • Anja Leichsenring +2
    • Patricia Tiedemann +1
    • Stefan Bürk +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Frank Nägler uploaded patch set 1 10/24/16, 14:06

  2. TYPO3com voted on patch set 1 V +1 10/24/16, 14:11 Completed build in 04m 45s on Mon, 24 Oct, 04:11 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4065

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 10/24/16, 15:19

  4. Patricia Tiedemann commented on patch set 1 CR +1 V +1 10/24/16, 15:32

    npm installs ├── @types/jasmine@2.5.35
  5. Anja Leichsenring voted on patch set 1 CR +2 V +2 10/24/16, 16:28

  6. Gerrit merged patch set 1 10/24/16, 16:28