Review main Merged

50352[BUGFIX] Implement CMS setRenderingContext for AbstractConditionViewHelper

Claus Due CR +2 V +2 Easy +20 −0 updated 10/25/16, 14:30

Commit message

This fixes an issue where the CMS specific overridden
setRenderingContext method on CMS AbstractConditionViewHelper is
not present because the class does not subclass the CMS
AbstractViewHelper (due to coupling concerns). Subsequently the
ControllerContext is not assigned in $this->controllerContext.

This inconsistency is fixed by adding the method just like it
appears in the AbstractViewHelper class, along with declaring
the property containing the ControllerContext.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Frederic Gaus +1
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Claus Due uploaded patch set 1 10/24/16, 22:21

  2. Claus Due updated the commit message in patch set 2 10/24/16, 22:22

  3. TYPO3com voted on patch set 2 V +1 10/24/16, 22:27 Completed build in 05m 33s on Tue, 25 Oct, 12:27 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4106

  4. TYPO3com voted on patch set 1 V +1 10/24/16, 22:27 Completed build in 06m 43s on Tue, 25 Oct, 12:27 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4105

  5. Frederic Gaus voted on patch set 2 CR +1 10/25/16, 14:22

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 10/25/16, 14:29

  7. Anja Leichsenring voted on patch set 2 CR +2 V +2 10/25/16, 14:30

  8. Gerrit merged patch set 2 10/25/16, 14:30