Review main Merged

50357[BUGFIX] Make extbase subclasses work with numeric types

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 10/25/16, 16:43

Commit message

The extbase subclasses configuration does currently not work with a
numeric database field that identifies the type of a record. This is
due to a strict comparison that compares the stringish TypoScript
value against the numeric database value.

Both values are casted to string to make the comparision work.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Michael Oehlhof +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Sascha Egerer uploaded patch set 1 10/25/16, 05:58

  2. TYPO3com voted on patch set 1 V +1 10/25/16, 06:04 Completed build in 05m 52s on Tue, 25 Oct, 08:04 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4113

  3. Michael Oehlhof voted on patch set 1 CR +1 10/25/16, 09:17

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 10/25/16, 16:40

  5. Anja Leichsenring voted on patch set 1 CR +2 V +2 10/25/16, 16:41

  6. Gerrit merged patch set 1 10/25/16, 16:41

  7. Christian Kuhn commented on patch set 2 10/25/16, 16:43

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d6b207e9347b4db26b945847527cdf62d481796d