Review main Merged Breaking

50358[!!!][TASK] Migrate lowlevel deleted records command to SymfonyConsole

Benni Mack CR +2 V +2 Hard +366 −117 updated 10/25/16, 19:46

Commit message

The lowlevel cleaner command for permanently delete records
in the database that have been previously marked as "deleted=1"
in the database is migrated to a Symfony Console command,
reducing the complexity and enhances the readability of the function.

Call it like this:
typo3/sysext/core/bin/typo3 cleanup:deletedrecords --dry-run -vv --pid=49 --depth=4

You can also use "-p" instead of "--pid", or "-d" instead of "--depth".

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2436

Show 611 earlier messages
  1. Benni Mack uploaded patch set 1 10/25/16, 07:30

  2. TYPO3com voted on patch set 1 V -1 10/25/16, 07:35 Completed build in 05m 25s on Tue, 25 Oct, 09:35 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4114

  3. Benni Mack uploaded patch set 2 10/25/16, 08:07

  4. TYPO3com voted on patch set 2 V -1 10/25/16, 08:13 Completed build in 05m 18s on Tue, 25 Oct, 10:13 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4115

  5. Benni Mack uploaded patch set 3 10/25/16, 08:50

  6. TYPO3com voted on patch set 3 V -1 10/25/16, 08:54 Completed build in 04m 33s on Tue, 25 Oct, 10:54 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4117

  7. Anja Leichsenring uploaded patch set 4 10/25/16, 10:24

  8. TYPO3com voted on patch set 4 V +1 10/25/16, 10:31 Completed build in 06m 39s on Tue, 25 Oct, 12:31 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4125

  9. Anja Leichsenring commented on patch set 5 10/25/16, 12:23

    Published edit on patch set 4.
  10. TYPO3com voted on patch set 5 V +1 10/25/16, 12:28 Completed build in 04m 45s on Tue, 25 Oct, 02:28 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4138

  11. Anja Leichsenring commented on patch set 5 CR +1 V +1 10/25/16, 12:32

    LOL :D
  1. Anja Leichsenring commented on patch set 5 V -1 10/25/16, 12:34

    actual action is not performed
  2. Anja Leichsenring uploaded patch set 6 10/25/16, 13:25

  3. Anja Leichsenring commented on patch set 6 CR +1 V +1 10/25/16, 13:29

    careful, don't test on an instance you still need. I accidently deleted everything during testing ;)
  4. TYPO3com voted on patch set 6 V +1 10/25/16, 13:30 Completed build in 05m 09s on Tue, 25 Oct, 03:30 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4142

  5. Wouter Wolters commented on patch set 6 10/25/16, 13:31

    DeletedRecordsCommand.php:136

    space too much before []

    DeletedRecordsCommand.php:150

    should we add the named parameters already like done in https://review.typo3.org/#/c/50090/ ?

    DeletedRecordsCommand.php:263

    typehint for SymfonyStyle?
  6. Anja Leichsenring updated the commit message in patch set 7 10/25/16, 13:31

  7. TYPO3com voted on patch set 7 V +1 10/25/16, 13:37 Completed build in 05m 19s on Tue, 25 Oct, 03:37 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4144

  8. Anja Leichsenring uploaded patch set 8 10/25/16, 13:38

  9. Anja Leichsenring commented on patch set 8 V -1 10/25/16, 13:39

    messed up, second please
  10. Anja Leichsenring uploaded patch set 9 10/25/16, 13:43

  11. TYPO3com voted on patch set 8 V +1 10/25/16, 13:45 Completed build in 06m 51s on Tue, 25 Oct, 03:45 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4145

  12. TYPO3com voted on patch set 9 V +1 10/25/16, 13:47 Completed build in 04m 03s on Tue, 25 Oct, 03:47 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4147

  13. Mark Watney commented on patch set 9 10/25/16, 13:53

    DeletedRecordsCommand.php:115

    I would prefer to not be funny here.
  14. Anja Leichsenring updated the commit message in patch set 10 10/25/16, 14:00

  15. TYPO3com voted on patch set 10 V +1 10/25/16, 14:05 Completed build in 04m 51s on Tue, 25 Oct, 04:05 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4149

  16. Benni Mack commented on patch set 11 10/25/16, 14:12

    Published edit on patch set 10.
  17. Anja Leichsenring voted on patch set 11 CR +1 V +1 10/25/16, 14:13

  18. TYPO3com voted on patch set 11 V +1 10/25/16, 14:16 Completed build in 04m 38s on Tue, 25 Oct, 04:16 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4151

  19. Philipp Gampe commented on patch set 11 CR -1 10/25/16, 14:21

    Output texts should be more serious.
  20. Benni Mack commented on patch set 12 10/25/16, 15:41

    Published edit on patch set 11.
  21. TYPO3com voted on patch set 12 V +1 10/25/16, 15:46 Completed build in 04m 37s on Tue, 25 Oct, 05:46 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4172

  22. Anja Leichsenring commented on patch set 12 CR +1 V +1 10/25/16, 16:40

    pity for the fun comments :(
  23. Wouter Wolters voted on patch set 12 CR +1 10/25/16, 19:40

  24. Wouter Wolters voted on patch set 12 CR +2 V +2 10/25/16, 19:46

  25. Gerrit merged patch set 12 10/25/16, 19:46