50358[!!!][TASK] Migrate lowlevel deleted records command to SymfonyConsole
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Anja Leichsenring +1
-
Verified V +2
- Wouter Wolters +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Breaking-78417-LowlevelDeletedRecordsCommandParametersChanged.rstnew+44 −0
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php4new+318 −0
- typo3/sysext/lowlevel/Classes/DeletedRecordsCommand.phpdeleted+0 −116
- typo3/sysext/lowlevel/Configuration/Commands.php+4 −0
- typo3/sysext/lowlevel/ext_localconf.php+0 −1
Review log 2436
Show 611 earlier messages
-
Benni Mack uploaded patch set 1 10/25/16, 07:30
-
TYPO3com voted on patch set 1 V -1 10/25/16, 07:35 Completed build in 05m 25s on Tue, 25 Oct, 09:35 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4114
-
Benni Mack uploaded patch set 2 10/25/16, 08:07
-
TYPO3com voted on patch set 2 V -1 10/25/16, 08:13 Completed build in 05m 18s on Tue, 25 Oct, 10:13 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4115
-
Benni Mack uploaded patch set 3 10/25/16, 08:50
-
TYPO3com voted on patch set 3 V -1 10/25/16, 08:54 Completed build in 04m 33s on Tue, 25 Oct, 10:54 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4117
-
Anja Leichsenring uploaded patch set 4 10/25/16, 10:24
-
TYPO3com voted on patch set 4 V +1 10/25/16, 10:31 Completed build in 06m 39s on Tue, 25 Oct, 12:31 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4125
-
Anja Leichsenring commented on patch set 5 10/25/16, 12:23
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 10/25/16, 12:28 Completed build in 04m 45s on Tue, 25 Oct, 02:28 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4138
-
Anja Leichsenring commented on patch set 5 CR +1 V +1 10/25/16, 12:32
LOL :D
-
Anja Leichsenring commented on patch set 5 V -1 10/25/16, 12:34
actual action is not performed -
Anja Leichsenring uploaded patch set 6 10/25/16, 13:25
-
Anja Leichsenring commented on patch set 6 CR +1 V +1 10/25/16, 13:29
careful, don't test on an instance you still need. I accidently deleted everything during testing ;) -
TYPO3com voted on patch set 6 V +1 10/25/16, 13:30 Completed build in 05m 09s on Tue, 25 Oct, 03:30 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4142
-
Wouter Wolters commented on patch set 6 10/25/16, 13:31
DeletedRecordsCommand.php:136space too much before []DeletedRecordsCommand.php:150should we add the named parameters already like done in https://review.typo3.org/#/c/50090/ ?DeletedRecordsCommand.php:263typehint for SymfonyStyle? -
Anja Leichsenring updated the commit message in patch set 7 10/25/16, 13:31
-
TYPO3com voted on patch set 7 V +1 10/25/16, 13:37 Completed build in 05m 19s on Tue, 25 Oct, 03:37 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4144
-
Anja Leichsenring uploaded patch set 8 10/25/16, 13:38
-
Anja Leichsenring commented on patch set 8 V -1 10/25/16, 13:39
messed up, second please -
Anja Leichsenring uploaded patch set 9 10/25/16, 13:43
-
TYPO3com voted on patch set 8 V +1 10/25/16, 13:45 Completed build in 06m 51s on Tue, 25 Oct, 03:45 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4145
-
TYPO3com voted on patch set 9 V +1 10/25/16, 13:47 Completed build in 04m 03s on Tue, 25 Oct, 03:47 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4147
-
Mark Watney commented on patch set 9 10/25/16, 13:53
DeletedRecordsCommand.php:115I would prefer to not be funny here. -
Anja Leichsenring updated the commit message in patch set 10 10/25/16, 14:00
-
TYPO3com voted on patch set 10 V +1 10/25/16, 14:05 Completed build in 04m 51s on Tue, 25 Oct, 04:05 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4149
-
Benni Mack commented on patch set 11 10/25/16, 14:12
Published edit on patch set 10. -
Anja Leichsenring voted on patch set 11 CR +1 V +1 10/25/16, 14:13
-
TYPO3com voted on patch set 11 V +1 10/25/16, 14:16 Completed build in 04m 38s on Tue, 25 Oct, 04:16 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4151
-
Philipp Gampe commented on patch set 11 CR -1 10/25/16, 14:21
Output texts should be more serious. -
Benni Mack commented on patch set 12 10/25/16, 15:41
Published edit on patch set 11. -
TYPO3com voted on patch set 12 V +1 10/25/16, 15:46 Completed build in 04m 37s on Tue, 25 Oct, 05:46 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4172
-
Anja Leichsenring commented on patch set 12 CR +1 V +1 10/25/16, 16:40
pity for the fun comments :( -
Wouter Wolters voted on patch set 12 CR +1 10/25/16, 19:40
-
Wouter Wolters voted on patch set 12 CR +2 V +2 10/25/16, 19:46
-
Gerrit merged patch set 12 10/25/16, 19:46