Review main Merged

50361[TASK] Fluidification of SuggestWizard

Marc Willmann CR +2 V +2 Normal +74 −23 updated 10/26/16, 17:52

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1621

  1. Marc Willmann uploaded patch set 1 10/25/16, 10:11

  2. TYPO3com voted on patch set 1 V -1 10/25/16, 10:17 Completed build in 05m 16s on Tue, 25 Oct, 12:17 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4120

  3. Michael Oehlhof commented on patch set 1 CR -1 10/25/16, 10:26

    SuggestWizard.html:5

    The TAB should be removed

    SuggestWizard.html:7

    The TAB should be removed
  4. Marc Willmann uploaded patch set 2 10/25/16, 10:58

  5. Marc Willmann uploaded patch set 3 10/25/16, 10:59

  6. TYPO3com voted on patch set 2 V +1 10/25/16, 11:05 Completed build in 07m 22s on Tue, 25 Oct, 01:05 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4128

  7. TYPO3com voted on patch set 3 V +1 10/25/16, 11:07 Completed build in 07m 18s on Tue, 25 Oct, 01:07 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4129

  8. Daniel Windloff commented on patch set 3 10/25/16, 12:08

    I'm still unsure about the relation between added loc and the aimed goal.

    SuggestWizard.php:97

    Move to the template and use f:translate

    SuggestWizard.html:8

    Use <core:icon vh instead.

    SuggestWizard.html:12

    Why manual hsc here
  9. Andreas Kienast commented on patch set 3 10/25/16, 12:22

    SuggestWizard.php:540

    I'd either do `$filename === null` or `empty($filename)`, the latter one is more bullet-proof, but that depends on the use-case of this protected method.
  10. Marc Willmann commented on patch set 3 10/25/16, 12:56

    SuggestWizard.php:97 Reply

    what exactly would be the advantage of doing this?

    SuggestWizard.php:540 Reply

    ok; I'll change this. But this case is just a fail-over which should never been called.

    SuggestWizard.html:8 Reply

    you're right; this is an error. I'll fix this.

    SuggestWizard.html:12 Reply

    because this field also run through hsc in the original code. Is it guaranteed that this will never been needed?
  11. Marc Willmann uploaded patch set 4 10/25/16, 13:17

  12. TYPO3com voted on patch set 4 V +1 10/25/16, 13:21 Completed build in 03m 57s on Tue, 25 Oct, 03:21 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4141

  13. Daniel Windloff commented on patch set 4 10/25/16, 14:57

    SuggestWizard.php:93

    Hi, I would move it completely to the template, as I think a static label should be part of the view.

    SuggestWizard.html:10

    The variables must be (obviously) encoded as there is a context change. Fluid encodes variables by default (except https://speakerdeck.com/helhum/fluid-xss?slide=7 for example). I don't see one of these cases (where fluid doesn't encode the variable itself) here at the first sight. That is why I ask ;-).
  14. Jan Helke commented on patch set 4 CR +1 10/25/16, 15:16

    SuggestWizard.html:6

    I got a broken search im age in the suggest wizard. I assume, that is somehow connected with this overlay.
  15. Jan Helke voted on patch set 4 CR -1 10/25/16, 15:16

  16. Marc Willmann uploaded patch set 5 10/25/16, 18:59

  17. Marc Willmann commented on patch set 4 10/25/16, 19:01

    SuggestWizard.html:6 Reply

    thanks for your attention. (y) Fixed it with the new patchset.
  18. TYPO3com voted on patch set 5 V +1 10/25/16, 19:05 Completed build in 05m 55s on Tue, 25 Oct, 09:05 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4185

  19. Christian Kuhn voted on patch set 5 CR +1 V +1 10/26/16, 17:51

  20. Anja Leichsenring voted on patch set 5 CR +2 V +2 10/26/16, 17:52

  21. Gerrit merged patch set 5 10/26/16, 17:52