50361[TASK] Fluidification of SuggestWizard
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1621
-
Marc Willmann uploaded patch set 1 10/25/16, 10:11
-
TYPO3com voted on patch set 1 V -1 10/25/16, 10:17 Completed build in 05m 16s on Tue, 25 Oct, 12:17 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4120
-
Michael Oehlhof commented on patch set 1 CR -1 10/25/16, 10:26
SuggestWizard.html:7The TAB should be removed -
Marc Willmann uploaded patch set 2 10/25/16, 10:58
-
Marc Willmann uploaded patch set 3 10/25/16, 10:59
-
TYPO3com voted on patch set 2 V +1 10/25/16, 11:05 Completed build in 07m 22s on Tue, 25 Oct, 01:05 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4128
-
TYPO3com voted on patch set 3 V +1 10/25/16, 11:07 Completed build in 07m 18s on Tue, 25 Oct, 01:07 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4129
-
Daniel Windloff commented on patch set 3 10/25/16, 12:08
I'm still unsure about the relation between added loc and the aimed goal.SuggestWizard.php:97Move to the template and use f:translateSuggestWizard.html:8Use <core:icon vh instead.SuggestWizard.html:12Why manual hsc here -
Andreas Kienast commented on patch set 3 10/25/16, 12:22
SuggestWizard.php:540I'd either do `$filename === null` or `empty($filename)`, the latter one is more bullet-proof, but that depends on the use-case of this protected method. -
Marc Willmann commented on patch set 3 10/25/16, 12:56
SuggestWizard.php:97Replywhat exactly would be the advantage of doing this?SuggestWizard.php:540Replyok; I'll change this. But this case is just a fail-over which should never been called.SuggestWizard.html:8Replyyou're right; this is an error. I'll fix this.SuggestWizard.html:12Replybecause this field also run through hsc in the original code. Is it guaranteed that this will never been needed? -
Marc Willmann uploaded patch set 4 10/25/16, 13:17
-
TYPO3com voted on patch set 4 V +1 10/25/16, 13:21 Completed build in 03m 57s on Tue, 25 Oct, 03:21 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4141
-
Daniel Windloff commented on patch set 4 10/25/16, 14:57
SuggestWizard.php:93Hi, I would move it completely to the template, as I think a static label should be part of the view.SuggestWizard.html:10The variables must be (obviously) encoded as there is a context change. Fluid encodes variables by default (except https://speakerdeck.com/helhum/fluid-xss?slide=7 for example). I don't see one of these cases (where fluid doesn't encode the variable itself) here at the first sight. That is why I ask ;-). -
Jan Helke commented on patch set 4 CR +1 10/25/16, 15:16
SuggestWizard.html:6I got a broken search im age in the suggest wizard. I assume, that is somehow connected with this overlay. -
Jan Helke voted on patch set 4 CR -1 10/25/16, 15:16
-
Marc Willmann uploaded patch set 5 10/25/16, 18:59
-
Marc Willmann commented on patch set 4 10/25/16, 19:01
SuggestWizard.html:6Replythanks for your attention. (y) Fixed it with the new patchset. -
TYPO3com voted on patch set 5 V +1 10/25/16, 19:05 Completed build in 05m 55s on Tue, 25 Oct, 09:05 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4185
-
Christian Kuhn voted on patch set 5 CR +1 V +1 10/26/16, 17:51
-
Anja Leichsenring voted on patch set 5 CR +2 V +2 10/26/16, 17:52
-
Gerrit merged patch set 5 10/26/16, 17:52
SuggestWizard.html:5