Review TYPO3_7-6 Merged

50376[BUGFIX] Adding back access to parentMenuArr and menuitem in subMenu

Christian Kuhn CR +2 V +2 Normal +96 −0 updated 10/25/16, 20:43

Commit message

Adding the possibility to access the menuArr and direct menuItem from
the parent menu in subMenu instances to provide the ability to check
for parent item information or parent sibling item informations.

Providing two getters and a combined setter, called in the subMenu
method to readd this data access instead of simple using the old
unsafe and undeclared property set.

Leaving the parentMenuArr member public for now, even it is not
nice.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn commented on patch set 1 10/25/16, 20:32

    Cherry Picked from branch master.
  2. Christian Kuhn voted on patch set 1 CR -1 10/25/16, 20:32

  3. Christian Kuhn uploaded patch set 2 10/25/16, 20:34

  4. TYPO3com voted on patch set 1 V +1 10/25/16, 20:39 Completed build in 07m 01s on Tue, 25 Oct, 10:39 PM Test Summary: 37994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-251

  5. TYPO3com voted on patch set 2 V +1 10/25/16, 20:41 Completed build in 06m 30s on Tue, 25 Oct, 10:41 PM Test Summary: 37994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-252

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 10/25/16, 20:43

  7. Gerrit merged patch set 2 10/25/16, 20:43