50377[TASK] Fluidification of ClearCacheToolbarItem
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Daniel Gohlke +1
- Gianluigi Martino +1
- Michael Oehlhof +1
-
Verified V +2
- Anja Leichsenring +2
- Daniel Gohlke +1
- Gianluigi Martino +1
- Michael Oehlhof +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php+38 −30
- typo3/sysext/backend/Resources/Private/Partials/ToolbarItems/ToolbarItem.htmlnew+4 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ClearCacheToolbarItem.htmlnew+1 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ClearCacheToolbarItemDropDown.htmlnew+19 −0
Review log 1114
-
Marc Willmann uploaded patch set 1 10/25/16, 21:04
-
TYPO3com voted on patch set 1 V +1 10/25/16, 21:08 Completed build in 04m 20s on Tue, 25 Oct, 11:08 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4193
-
Gianluigi Martino uploaded patch set 2 10/26/16, 09:19
-
Daniel Gohlke commented on patch set 1 CR +1 V +1 10/26/16, 09:19
Looks good to me. -
TYPO3com voted on patch set 2 V +1 10/26/16, 09:24 Completed build in 05m 03s on Wed, 26 Oct, 11:24 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4207
-
Daniel Gohlke commented on patch set 2 CR -1 10/26/16, 09:25
I won't change the link behaviour. Using the LinkViewHelper is correct. I won't link the icon. -
Marc Willmann uploaded patch set 3 10/26/16, 09:43
-
Marc Willmann commented on patch set 3 10/26/16, 09:46
I'm against mixing up different tickets for this; I have improved the code by using des f:link vh, but this patch should deliver exact same HTML output as before Fluidification. -
TYPO3com voted on patch set 3 V +1 10/26/16, 09:48 Completed build in 04m 28s on Wed, 26 Oct, 11:48 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4210
-
Gianluigi Martino voted on patch set 3 CR +1 V +1 10/26/16, 09:49
-
Daniel Gohlke voted on patch set 3 CR +1 V +1 10/26/16, 09:52
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 10/26/16, 12:06
-
Anja Leichsenring voted on patch set 3 CR +2 V +2 10/26/16, 14:33
-
Gerrit merged patch set 3 10/26/16, 14:33