Review main Merged Breaking

50378[!!!][TASK] Migrate FlexForm cleaning command to Symfony Console

Benni Mack CR +2 V +2 Hard +343 −153 updated 10/27/16, 06:44

Commit message

The lowlevel cleaner command for cleaning FlexForm XMLs
in the database (e.g. when a flexform has changed) is migrated to
a Symfony Console command, reducing the complexity and
enhancing the readability of the logic.

Call it like this:
typo3/sysext/core/bin/typo3 cleanup:flexforms --dry-run -vv --pid=49 --depth=4

You can also use "-p" instead of "--pid", or "-d" instead of "--depth".

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 912

  1. Benni Mack uploaded patch set 1 10/25/16, 22:52

  2. TYPO3com voted on patch set 1 V -1 10/25/16, 22:58 Completed build in 05m 38s on Wed, 26 Oct, 12:58 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4194

  3. Wouter Wolters commented on patch set 1 10/26/16, 06:36

    CleanFlexFormsCommand.php:127

    array typehint

    CleanFlexFormsCommand.php:134

    $cfg $config

    CleanFlexFormsCommand.php:146

    use named parameter

    CleanFlexFormsCommand.php:178

    namedparameter

    CleanFlexFormsCommand.php:210

    use php7 typehints
  4. Benni Mack uploaded patch set 2 10/26/16, 08:21

  5. TYPO3com voted on patch set 2 V -1 10/26/16, 08:25 Completed build in 04m 03s on Wed, 26 Oct, 10:25 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4206

  6. Benni Mack uploaded patch set 3 10/26/16, 10:09

  7. TYPO3com voted on patch set 3 V +1 10/26/16, 10:14 Completed build in 04m 57s on Wed, 26 Oct, 12:14 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4215

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 10/26/16, 15:23

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 10/26/16, 16:25

  10. Gerrit merged patch set 3 10/26/16, 16:26

  11. Josef Glatz commented on patch set 4 10/27/16, 03:52

    Is it intended that the task isn't shown when running "./typo3/sysext/core/bin/typo3 extbase help" or "./typo3/sysext/core/bin/typo3"? (typo3 console also don't show it as available task)
  12. Wouter Wolters commented on patch set 4 10/27/16, 06:44

    I have a related change pending at https://review.typo3.org/#/c/47475/2