50378[!!!][TASK] Migrate FlexForm cleaning command to Symfony Console
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Breaking-78439-LowlevelFlexFormsCleaningCommandParametersChanged.rstnew+44 −0
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php5new+295 −0
- typo3/sysext/lowlevel/Classes/CleanFlexformCommand.phpdeleted+0 −152
- typo3/sysext/lowlevel/Configuration/Commands.php+4 −0
- typo3/sysext/lowlevel/ext_localconf.php+0 −1
Review log 912
-
Benni Mack uploaded patch set 1 10/25/16, 22:52
-
TYPO3com voted on patch set 1 V -1 10/25/16, 22:58 Completed build in 05m 38s on Wed, 26 Oct, 12:58 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4194
-
Wouter Wolters commented on patch set 1 10/26/16, 06:36
CleanFlexFormsCommand.php:134$cfg $configCleanFlexFormsCommand.php:146use named parameterCleanFlexFormsCommand.php:178namedparameterCleanFlexFormsCommand.php:210use php7 typehints -
Benni Mack uploaded patch set 2 10/26/16, 08:21
-
TYPO3com voted on patch set 2 V -1 10/26/16, 08:25 Completed build in 04m 03s on Wed, 26 Oct, 10:25 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4206
-
Benni Mack uploaded patch set 3 10/26/16, 10:09
-
TYPO3com voted on patch set 3 V +1 10/26/16, 10:14 Completed build in 04m 57s on Wed, 26 Oct, 12:14 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4215
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 10/26/16, 15:23
-
Christian Kuhn voted on patch set 3 CR +2 V +2 10/26/16, 16:25
-
Gerrit merged patch set 3 10/26/16, 16:26
-
Josef Glatz commented on patch set 4 10/27/16, 03:52
Is it intended that the task isn't shown when running "./typo3/sysext/core/bin/typo3 extbase help" or "./typo3/sysext/core/bin/typo3"? (typo3 console also don't show it as available task) -
Wouter Wolters commented on patch set 4 10/27/16, 06:44
I have a related change pending at https://review.typo3.org/#/c/47475/2
CleanFlexFormsCommand.php:127