Review main Merged

50380[TASK] Switches TcaMigrationsCheck to Ajax

Patricia Tiedemann CR +2 V +2 Hard +347 −87 updated 10/27/16, 14:21

Commit message

Similar to the "TCA in ext_tables.php check" the "TCA Migrations"
check now uses Ajax to show its results.

Most of this check's code logic itself hasn't been modified, only
moved to a different class.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 2230

Show 45 earlier messages
  1. Patricia Tiedemann uploaded patch set 1 10/26/16, 09:49

  2. TYPO3com voted on patch set 1 V -1 10/26/16, 09:53 Completed build in 04m 37s on Wed, 26 Oct, 11:53 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4211

  3. Wouter Wolters commented on patch set 1 10/26/16, 09:55

    TcaMigrationsCheck.php:22

    empty line can be removed.

    TcaMigrationsCheck.php:44

    indenting seems a bit off here

    TcaMigrationsCheck.php:55

    LoadTcaService is available as use statement. This can be shortened.
  4. Michael Oehlhof commented on patch set 1 10/26/16, 09:55

    php
  5. Patricia Tiedemann updated the commit message in patch set 2 10/26/16, 10:08

  1. Patricia Tiedemann uploaded patch set 3 10/26/16, 10:12

  2. TYPO3com voted on patch set 2 V -1 10/26/16, 10:14 Completed build in 06m 22s on Wed, 26 Oct, 12:14 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4214

  3. TYPO3com voted on patch set 3 V -1 10/26/16, 10:17 Completed build in 04m 41s on Wed, 26 Oct, 12:16 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4216

  4. Marco Bresch commented on patch set 4 10/26/16, 10:47

    Published edit on patch set 3.
  5. TYPO3com voted on patch set 4 V +1 10/26/16, 10:52 Completed build in 04m 56s on Wed, 26 Oct, 12:52 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4219

  6. Wouter Wolters voted on patch set 4 CR +1 10/26/16, 11:02

  7. Marco Bresch commented on patch set 4 V -1 10/26/16, 11:23

    Works fine! But: The color of the message box was orange and is red now. The box should be in orange, should'n be?
  8. Patricia Tiedemann uploaded patch set 5 10/26/16, 11:34

  9. TYPO3com voted on patch set 5 V +1 10/26/16, 11:38 Completed build in 03m 58s on Wed, 26 Oct, 01:38 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4221

  10. Marco Bresch voted on patch set 5 V +1 10/26/16, 11:38

  11. Marco Bresch commented on patch set 5 CR -1 10/26/16, 12:10

    TcaMigrationsCheck.php:41

    As discussed: I think it is possible to remove the last HTML-Tags here. ;-)
  12. Wouter Wolters commented on patch set 5 10/26/16, 19:11

    TcaMigrationsCheck.php:2

    can we apply PHP7 strict_type here and adjust the class accordingly?

    TcaMigrationsCheck.php:23

    remove empty line

    TcaMigrationsCheck.php:41 Reply

    What do you mean here? Removing any HTML tag here will lead to invalid HTML IMO.
  13. Marco Bresch commented on patch set 5 10/27/16, 08:07

    TcaMigrationsCheck.php:41 Reply

    Something like Fluidfication or put the messages in an array to return an json.
  14. Wouter Wolters commented on patch set 5 10/27/16, 08:19

    TcaMigrationsCheck.php:41 Reply

    JSON is ok for me but please do not use Fluid here for such a small thing. That is performance wise not the best choice.
  15. Patricia Tiedemann uploaded patch set 6 10/27/16, 13:54

  16. TYPO3com voted on patch set 6 V -1 10/27/16, 14:00 Completed build in 05m 17s on Thu, 27 Oct, 04:00 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4338

  17. Patricia Tiedemann uploaded patch set 7 10/27/16, 14:04

  18. Christian Kuhn voted on patch set 7 CR +1 V +1 10/27/16, 14:09

  19. TYPO3com voted on patch set 7 V +1 10/27/16, 14:09 Completed build in 04m 38s on Thu, 27 Oct, 04:09 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4339

  20. Christian Kuhn voted on patch set 7 CR -1 V 0 10/27/16, 14:10

  21. Patricia Tiedemann uploaded patch set 8 10/27/16, 14:12

  22. Christian Kuhn voted on patch set 8 CR +1 V +1 10/27/16, 14:15

  23. TYPO3com voted on patch set 8 V +1 10/27/16, 14:19 Completed build in 06m 52s on Thu, 27 Oct, 04:19 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4341

  24. Anja Leichsenring voted on patch set 8 CR +2 V +2 10/27/16, 14:21

  25. Gerrit merged patch set 8 10/27/16, 14:21