50380[TASK] Switches TcaMigrationsCheck to Ajax
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/install/Classes/Controller/Action/Ajax/TcaExtTablesCheck.php+54 −6
- typo3/sysext/install/Classes/Controller/Action/Ajax/TcaMigrationsCheck.php9new+88 −0
- typo3/sysext/install/Classes/Controller/Action/Tool/ImportantActions.php+1 −34
- typo3/sysext/install/Classes/Controller/AjaxController.php+2 −1
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/TcaExtTablesCheck.html+4 −13
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/TcaMigrations.htmldeleted+0 −8
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/TcaMigrationsCheck.htmlnew+16 −0
- typo3/sysext/install/Resources/Private/Templates/Action/Tool/ImportantActions.html+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Install.js+181 −24
Review log 2230
Show 45 earlier messages
-
Patricia Tiedemann uploaded patch set 1 10/26/16, 09:49
-
TYPO3com voted on patch set 1 V -1 10/26/16, 09:53 Completed build in 04m 37s on Wed, 26 Oct, 11:53 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4211
-
Wouter Wolters commented on patch set 1 10/26/16, 09:55
TcaMigrationsCheck.php:44indenting seems a bit off hereTcaMigrationsCheck.php:55LoadTcaService is available as use statement. This can be shortened. -
Michael Oehlhof commented on patch set 1 10/26/16, 09:55
php -
Patricia Tiedemann updated the commit message in patch set 2 10/26/16, 10:08
-
Patricia Tiedemann uploaded patch set 3 10/26/16, 10:12
-
TYPO3com voted on patch set 2 V -1 10/26/16, 10:14 Completed build in 06m 22s on Wed, 26 Oct, 12:14 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4214
-
TYPO3com voted on patch set 3 V -1 10/26/16, 10:17 Completed build in 04m 41s on Wed, 26 Oct, 12:16 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4216
-
Marco Bresch commented on patch set 4 10/26/16, 10:47
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 10/26/16, 10:52 Completed build in 04m 56s on Wed, 26 Oct, 12:52 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4219
-
Wouter Wolters voted on patch set 4 CR +1 10/26/16, 11:02
-
Marco Bresch commented on patch set 4 V -1 10/26/16, 11:23
Works fine! But: The color of the message box was orange and is red now. The box should be in orange, should'n be? -
Patricia Tiedemann uploaded patch set 5 10/26/16, 11:34
-
TYPO3com voted on patch set 5 V +1 10/26/16, 11:38 Completed build in 03m 58s on Wed, 26 Oct, 01:38 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4221
-
Marco Bresch voted on patch set 5 V +1 10/26/16, 11:38
-
Marco Bresch commented on patch set 5 CR -1 10/26/16, 12:10
TcaMigrationsCheck.php:41As discussed: I think it is possible to remove the last HTML-Tags here. ;-) -
Wouter Wolters commented on patch set 5 10/26/16, 19:11
TcaMigrationsCheck.php:2can we apply PHP7 strict_type here and adjust the class accordingly?TcaMigrationsCheck.php:23remove empty lineTcaMigrationsCheck.php:41ReplyWhat do you mean here? Removing any HTML tag here will lead to invalid HTML IMO. -
Marco Bresch commented on patch set 5 10/27/16, 08:07
TcaMigrationsCheck.php:41ReplySomething like Fluidfication or put the messages in an array to return an json. -
Wouter Wolters commented on patch set 5 10/27/16, 08:19
TcaMigrationsCheck.php:41ReplyJSON is ok for me but please do not use Fluid here for such a small thing. That is performance wise not the best choice. -
Patricia Tiedemann uploaded patch set 6 10/27/16, 13:54
-
TYPO3com voted on patch set 6 V -1 10/27/16, 14:00 Completed build in 05m 17s on Thu, 27 Oct, 04:00 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4338
-
Patricia Tiedemann uploaded patch set 7 10/27/16, 14:04
-
Christian Kuhn voted on patch set 7 CR +1 V +1 10/27/16, 14:09
-
TYPO3com voted on patch set 7 V +1 10/27/16, 14:09 Completed build in 04m 38s on Thu, 27 Oct, 04:09 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4339
-
Christian Kuhn voted on patch set 7 CR -1 V 0 10/27/16, 14:10
-
Patricia Tiedemann uploaded patch set 8 10/27/16, 14:12
-
Christian Kuhn voted on patch set 8 CR +1 V +1 10/27/16, 14:15
-
TYPO3com voted on patch set 8 V +1 10/27/16, 14:19 Completed build in 06m 52s on Thu, 27 Oct, 04:19 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4341
-
Anja Leichsenring voted on patch set 8 CR +2 V +2 10/27/16, 14:21
-
Gerrit merged patch set 8 10/27/16, 14:21
TcaMigrationsCheck.php:22