Review main Merged

50381[TASK] Improve acceptance test for extensionmanager

Marco Bresch CR +2 V +2 Normal +23 −30 updated 10/26/16, 17:35

Commit message

Summarize two tests in one test to uninstall and install the belog extension.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Marco Bresch uploaded patch set 1 10/26/16, 10:00

  2. TYPO3com voted on patch set 1 V +1 10/26/16, 10:05 Completed build in 05m 25s on Wed, 26 Oct, 12:05 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4213

  3. Daniel Gohlke voted on patch set 1 CR +1 V +1 10/26/16, 12:49

  4. Daniel Gohlke commented on patch set 1 CR 0 10/26/16, 13:27

    I think we should use a less critical extension. In case on an error in uninstalling and installing the beuser extension, more acceptance tests will fail. Lets use the belog extension.
  5. Marco Bresch commented on patch set 1 10/26/16, 13:34

    Good point! As discussed I will put the two tests (uninstall and install) in one test to get the same setup before and after the test.
  6. Marco Bresch uploaded patch set 2 10/26/16, 14:50

  7. TYPO3com voted on patch set 2 V +1 10/26/16, 15:00 Completed build in 09m 54s on Wed, 26 Oct, 05:00 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4245

  8. Anja Leichsenring voted on patch set 2 CR +1 10/26/16, 17:17

  9. Anja Leichsenring voted on patch set 2 V +1 10/26/16, 17:20

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 10/26/16, 17:35

  11. Gerrit merged patch set 2 10/26/16, 17:35