Review main Merged

50382[TASK] Add acceptance test for ModuleMenuButton on resize

Gordon Brüggemann CR +2 V +2 Normal +98 −0 updated 10/26/16, 17:30

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. Gordon Brüggemann uploaded patch set 1 10/26/16, 11:42

  2. TYPO3com voted on patch set 1 V +1 10/26/16, 11:47 Completed build in 05m 07s on Wed, 26 Oct, 01:47 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4223

  3. Mathias Brodala commented on patch set 2 10/26/16, 12:46

    Published edit on patch set 1.
  4. Mathias Brodala commented on patch set 2 10/26/16, 12:46

    Reworded, used more comment methods from CodeCeption, renamed Cest from "Buttom" to "Button". ;-)
  5. TYPO3com voted on patch set 2 V -1 10/26/16, 12:50 Completed build in 03m 48s on Wed, 26 Oct, 02:50 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4227

  6. Mathias Brodala uploaded patch set 3 10/26/16, 12:55

  7. Mathias Brodala commented on patch set 3 10/26/16, 12:55

    Fixed CGL error: renamed test file name to class name.
  8. TYPO3com voted on patch set 3 V -1 10/26/16, 12:59 Completed build in 04m 35s on Wed, 26 Oct, 02:59 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4228

  9. Mathias Brodala uploaded patch set 4 10/26/16, 13:03

  10. Mathias Brodala commented on patch set 4 10/26/16, 13:03

    Fixed wrong comment type for license block, added class docblock.
  11. TYPO3com voted on patch set 4 V +1 10/26/16, 13:09 Completed build in 05m 32s on Wed, 26 Oct, 03:09 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4230

  12. Anja Leichsenring voted on patch set 4 CR +1 V +1 10/26/16, 17:20

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 10/26/16, 17:30

  14. Gerrit merged patch set 4 10/26/16, 17:30