50383[BUGFIX] Legacy class name usage
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Anja Leichsenring +1
- Christian Kuhn +1
Issues 1
Files 1
Review log 1215
-
Markus Klein uploaded patch set 1 10/26/16, 13:02
-
TYPO3com voted on patch set 1 V -1 10/26/16, 13:07 Completed build in 05m 18s on Wed, 26 Oct, 03:07 PM Test Summary: 2 of 19569 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4229
-
Christian Kuhn commented on patch set 1 10/26/16, 17:39
weird. maybe storm is wrong here? -
Markus Klein commented on patch set 1 10/26/16, 18:30
Storm's sources say the $timestamp parameter has a typehint, so the docs say: http://php.net/manual/en/datetime.createfromformat.php -
Markus Klein uploaded patch set 2 10/26/16, 18:31
-
TYPO3com voted on patch set 2 V +1 10/26/16, 18:36 Completed build in 04m 07s on Wed, 26 Oct, 08:36 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4269
-
Anja Leichsenring commented on patch set 2 10/27/16, 07:48
Markus, this patch now only switches sequence of two use statements. Are you sure about that? -
Wouter Wolters commented on patch set 2 CR +1 V +1 10/27/16, 07:52
Anja, you need more coffe :-) have a really close look at the change. TYPO3/CMS/Fluid -> TYPO3Fluid -
Anja Leichsenring commented on patch set 2 10/27/16, 07:57
okay, saw it now. The commit message needs to be adjusted, would you agree? *having more coffee* -
Christian Kuhn uploaded patch set 3 10/27/16, 11:11
-
Christian Kuhn voted on patch set 3 CR +1 V +1 10/27/16, 11:11
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 10/27/16, 11:12
-
Wouter Wolters voted on patch set 3 CR +2 V +2 10/27/16, 11:13
-
Gerrit merged patch set 3 10/27/16, 11:13
-
TYPO3com commented on patch set 3 10/27/16, 11:15 Completed build in 04m 01s on Thu, 27 Oct, 01:15 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4316