Review main Merged

50386[BUGFIX] Pass correct query parameter to image manipulation view

Philip Majewski CR +2 V +2 Easy +1 −1 updated 10/26/16, 17:24

Commit message

The TCA type "imageManipulation" has a boolean config called "enableZoom".
As declared in "ImageManipulationElement" this config will be added to
the "ImageManipulationWizard" wizardData in a key called "zoom".
But "ImageManipulationWizard" assigns a non existing key "bool".

So "enableZoom" set to true or false will always result in false.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Philip Majewski uploaded patch set 1 10/26/16, 14:18

  2. TYPO3com voted on patch set 1 V +1 10/26/16, 14:24 Completed build in 06m 45s on Wed, 26 Oct, 04:24 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4237

  3. Philip Majewski updated the commit message in patch set 2 10/26/16, 14:43

  4. Daniel Goerz voted on patch set 2 CR +1 10/26/16, 14:43

  5. TYPO3com voted on patch set 2 V +1 10/26/16, 14:49 Completed build in 06m 15s on Wed, 26 Oct, 04:49 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4242

  6. Andreas Kienast voted on patch set 2 CR +1 10/26/16, 17:09

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 10/26/16, 17:23

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 10/26/16, 17:23

  9. Gerrit merged patch set 2 10/26/16, 17:23

  10. Christian Kuhn commented on patch set 3 10/26/16, 17:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit b08b91bda980f9fbafc00f4d4cb2501c59383dd0