50389[FEATURE] Introduce PreviewRenderer pattern
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Preview/PreviewRendererInterface.phpnew+82 −0
- typo3/sysext/backend/Classes/Preview/PreviewRendererResolverInterface.phpnew+33 −0
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php4new+450 −0
- typo3/sysext/backend/Classes/Preview/StandardPreviewRendererResolver.php7new+88 −0
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php1+20 −191
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record/Footer.html+6 −6
- typo3/sysext/backend/ext_localconf.php+5 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-90348-PageLayoutViewClassInternalIsDeprecated.rst+4 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-78450-IntroducePreviewRendererPattern.rstnew+158 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+1 −0
Review log 81113
Show 6388 earlier messages
-
Claus Due uploaded patch set 1 10/26/16, 15:24
-
TYPO3com voted on patch set 1 V -1 10/26/16, 15:28 Completed build in 04m 02s on Wed, 26 Oct, 05:28 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4249
-
Andreas Kienast commented on patch set 1 CR -1 10/26/16, 16:19
StandardPreviewRendererResolver.php:37Second argument (timestamp) is missing -
Claus Due commented on patch set 1 10/26/16, 20:15
StandardPreviewRendererResolver.php:26Reply$typeConfiguration should become true indeed. But the check below prevents errors from trying to access this boolean as if it were an array (empty function won't raise such errors). The variable is only actually read if it can be accessed as array. The check is meant as a short way to check: 1) table has a type field, 2) type field's config is present. I didn't know if perhaps there is a core API to do this... input welcome!StandardPreviewRendererResolver.php:37ReplyAh yes, I keep forgetting we do that in CMS. Too much Fluid work lately (is that a thing? Too much...?) :) -
Claus Due uploaded patch set 2 10/26/16, 20:15
-
TYPO3com voted on patch set 2 V -1 10/26/16, 20:19 Completed build in 03m 59s on Wed, 26 Oct, 10:19 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4277
-
Claus Due uploaded patch set 3 10/26/16, 22:19
-
TYPO3com voted on patch set 3 V -1 10/26/16, 22:24 Completed build in 04m 25s on Thu, 27 Oct, 12:24 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4282
-
Claus Due uploaded patch set 4 10/26/16, 22:47
-
TYPO3com voted on patch set 4 V -1 10/26/16, 22:51 Completed build in 03m 53s on Thu, 27 Oct, 12:51 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4283
-
Claus Due uploaded patch set 5 10/26/16, 22:52
-
TYPO3com voted on patch set 5 V +1 10/26/16, 22:57 Completed build in 04m 44s on Thu, 27 Oct, 12:57 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4284
-
Anja Leichsenring commented on patch set 5 10/27/16, 07:50
Please remember to add a feature rst with documentation and examples how to use it. Thanks. -
Georg Ringer commented on patch set 5 10/28/16, 07:27
can you add return type declarations for the new classes? we can do that there -
Claus Due commented on patch set 5 10/28/16, 11:10
@Georg I'm not sure what you mean? All methods should have proper return type declarations - I reviewed them again just now to make sure. Did I miss some? -
Claus Due uploaded patch set 6 10/30/16, 12:34
-
TYPO3com voted on patch set 6 V -1 10/30/16, 12:39 Completed build in 04m 39s on Sun, 30 Oct, 01:39 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4421
-
Claus Due uploaded patch set 7 10/30/16, 12:59
-
Claus Due uploaded patch set 8 10/30/16, 13:01
-
Claus Due commented on patch set 8 10/30/16, 13:01
RST added, strict mode input and return types declared. -
TYPO3com voted on patch set 7 V -1 10/30/16, 13:03 Completed build in 04m 44s on Sun, 30 Oct, 02:03 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4424
-
TYPO3com voted on patch set 8 V +1 10/30/16, 13:06 Completed build in 04m 49s on Sun, 30 Oct, 02:06 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4425
-
Anja Leichsenring commented on patch set 9 11/05/16, 14:31
Published edit on patch set 8. -
Anja Leichsenring commented on patch set 10 11/05/16, 14:35
Published edit on patch set 9. -
TYPO3com voted on patch set 9 V +1 11/05/16, 14:35 Completed build in 04m 25s on Sat, 5 Nov, 03:35 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4614
-
Anja Leichsenring commented on patch set 10 CR +1 V +1 11/05/16, 14:36
Nice one, Claus. Thank you. -
TYPO3com voted on patch set 10 V +1 11/05/16, 14:41 Completed build in 05m 43s on Sat, 5 Nov, 03:41 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4615
-
Markus Klein commented on patch set 10 CR -1 11/08/16, 13:02
Please incorporate the DependencyOrderingService to give exts the possibility to register for such hooks without being dependent on the ext loading order -
Claus Due uploaded patch set 11 11/08/16, 13:04
-
Wouter Wolters commented on patch set 11 11/08/16, 13:08
StandardPreviewRendererResolver.php:4license header missingStandardPreviewRendererResolver.php:4license header missingStandardPreviewRendererResolver.php:22@throws missing -
Markus Klein commented on patch set 11 CR -1 11/08/16, 13:09
my last comment still applies -
TYPO3com voted on patch set 11 V +1 11/08/16, 13:10 Completed build in 05m 59s on Tue, 8 Nov, 02:10 PM Test Summary: 55247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4708
-
Claus Due uploaded patch set 12 11/08/16, 13:43
-
Claus Due commented on patch set 12 11/08/16, 13:43
Fixed cosmetics, did not implement dependencyorderingservice since this is TCA. -
TYPO3com voted on patch set 12 V +1 11/08/16, 13:48 Completed build in 05m 37s on Tue, 8 Nov, 02:48 PM Test Summary: 55247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4710
-
Markus Klein commented on patch set 12 11/08/16, 14:13
Short summary of my points as discussed on Slack: - TCA is the wrong place to define such configuration -> page TSconfig - Renderer should be a dedicated one per type and channel and not a renderer per type only which includes possible renderings per channel - Registration of the renderers per type/channel should not depend on the ext loading order - Renderers may depend on the actual (storage) page, hence page TSconfig seems to appropriate again -
Claus Due commented on patch set 12 11/18/16, 11:35
> TCA is the wrong place to define such configuration -> page TSconfig I strongly disagree but perhaps we can compromise. If you would consider TCA the default setting and enable overriding this via pageTSconfig I would accept that. And would then prefer that the pageTSconfig overriding gets done as a separate FEATURE. > Renderer should be a dedicated one per type and channel and not a renderer per type only which includes possible renderings per channel Sounds good in theory but is not possible to achieve at the current state due to how tightly connected legacy previews are to the pre-configured PageLayoutView. Once that gets deprecated we would be able to completely remove any dependency on PageLayoutView but until that time: any hook etc. which connects with page module preview rendering is and will for some time need to either depend on PageLayoutView or introduce a sufficiently weak signature in order to fit arbitrary channels. > Registration of the renderers per type/channel should not depend on the ext loading order The default value should, imho, do just that. Ext A depends on ext B if ext B has to change *any* defaults added in *any* TCA or action performed in any ext_* file or TCA override. > Renderers may depend on the actual (storage) page, hence page TSconfig seems to appropriate again Hopefully we can compromise and view it as two separate features. One (this one) to add the feature and contracts. Then another to configure those features in other ways than the most basic one. -
Markus Klein commented on patch set 12 11/21/16, 23:10
Defaults in TCA would be okay'ish, but pageTS options must be part of the initial API IMO. Not sure if I understand your argument about the legacy dependencies. If we have fallback in place, we by default fall back to the BE channel and thus any hook would still work, right. So no blocker to implement proper registry for renderers. My opinion about implicit orderings is set: I f*** hate this. Implicit stuff is always bad, especially if there is no sane way to workaround it. If pageTS is getting used, the last argument is superfluous, since we get that for free. -
Claus Due commented on patch set 12 11/22/16, 09:27
> My opinion about implicit orderings is set: I f*** hate this. Funny, that's my exact opinion about requiring configuration to exist in database! > Implicit stuff is always bad, especially if there is no sane way to workaround it. And DB-overridden stuff where configuration can exist in multiple pages (for pageTSconfig: global, page, usergroup and possibly some I don't even know about). I would advise that we try to actively steer away from this "needs to be in pageTSconfig" thinking. This is why I located this in TCA and made it possible to declare for each type. This also means steering away from configuring this with various fields in backend user / user group settings. But this is just my opinion. Just like the "please not in TCA" thing is your opinion ;) -
Anja Leichsenring commented on patch set 12 12/04/16, 10:43
how to proceed here? As far as I can read, no agreement has been reached, yet. -
Claus Due commented on patch set 12 12/04/16, 11:18
No agreement yet, no. One vote for "basics in TCA, no pageTSconfig in this merge request" and another for "move everything to pageTSconfig" which I've stated some technical objections to. Would like more votes, whichever way they fall :) -
Alexander Stehlik commented on patch set 12 12/04/16, 12:14
IMO it is sufficient to provide the TCA configuration. We are talking about preview rendering in the Backend not preview links (which might point to different locations depending on the current location of the page in the pagetree). The suggested architecture allows to implement your own renderer resolver. If you really need Page TSconfig you can implement your own. One thing I would add: In the resolveRendererFor() method I would pass in the ID of the current page. This would make page ID dependent configurations easier. -
Claus Due commented on patch set 12 12/04/16, 12:40
> One thing I would add: In the resolveRendererFor() method I would pass in the ID of the current page. That's a very good point, Alexander. I will update the merge request. Note: page UID can come from quite a lot of different places if this at some point gets used for previewing of arbitrary records, but it will be possible to consistently pass the UID from current implementers. Previewing in for example custom BE modules then need to retrieve this UID and pass it, but that's not a big issue IMHO. -
Claus Due uploaded patch set 13 09/02/17, 23:55
-
TYPO3com voted on patch set 13 V -1 09/02/17, 23:55 Completed build in 09s on Sun, 3 Sep, 01:55 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14183
-
Claus Due uploaded patch set 14 09/02/17, 23:58
-
TYPO3com voted on patch set 14 V -1 09/03/17, 00:12 Completed build in 13m 39s on Sun, 3 Sep, 02:12 AM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14184
-
TYPO3com voted on patch set 14 V +1 09/03/17, 00:16 Completed build in 31m 10s on Sun, 3 Sep, 02:16 AM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14184
-
Claus Due uploaded patch set 15 09/03/17, 01:08
-
Claus Due commented on patch set 15 09/03/17, 01:11
Patch has been updated: PreviewRendererResolver now also takes a page UID argument (which defaults to UID read from the page record that sits on PageLayoutView). And I added a secondary way to configure and look up which PreviewRenderer to use when the TCA type has a subtype_value_field like tt_content.list_type. In this case, the TCA can contain a sub-array of per-list-type implementations. See RST for details. I would like if we could revive this one. I will give the following arguments to consider: * Given that the PreviewRendererResolver now accepts a page UID it would be perfectly possible for any developer to replace the default implementation of the Resolver to one that - for example - reads TypoScript, record properties, has a priority-and-dependency based registry, and so on. These imaginative implementations, while all perfectly valid, make so much sense as extensions rather than shipped core behaviors. * Rather than thinking of this as a BE configuration option, think of it as "defining which implementation to use". When you have this as your perspective, it makes perfect sense that this must be configured on the PHP side, and here TCA is absolutely ideal because it already contains the table-and-type specific configuration and all we need is a new flag here which allows you to override the implementation either per type or per table. * Regarding loading order: the PreviewRenderer is not intended to be prioritised and so does not get resolved based on multiple potential renderer class names. Therefore, there is no dependency ordering (one renderer cannot depend on another). The one place that *would* benefit from such a change is the legacy drawItem hook, but implementing dependency ordering for it is beyond the scope of this change. The current change is an improvement already in that it allows you to change the renderer for a single TCA type; as opposed to the legacy hook which would require you to check the $row CType attribute and could see hook A prevent hook B from doing anything (affected both by loading order *and* a flag passed by reference). Perspectives about following changes that make sense: * Deprecating the current page layout preview hook interface and methods can be done since we now have an alternative. * A particular FluidPreviewRenderer can be created to replace the old Fluid based rendering that's mixed in with the old preview renderer. * Each of the current CType-based previews can be separated into individual renderers which are easier to replace with TCA overrides. * We could add an ExtbasePluginPreviewRenderer that automatically attaches itself when creating new plugin/CTypes and calls a controller method on the default controller of the plugin. Hopefully those perspectives help explain why the TCA solution was chosen over pageTSconfig, and why I don't think loading order has significance - in this case, because I completely agree it has in a lot of other cases. -
TYPO3com voted on patch set 15 V -1 09/03/17, 01:25 Completed build in 16m 49s on Sun, 3 Sep, 03:25 AM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14185
-
TYPO3com voted on patch set 15 V +1 09/03/17, 01:27 Completed build in 35m 34s on Sun, 3 Sep, 03:27 AM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14185
-
Anja Leichsenring commented on patch set 15 02/06/18, 20:59
@Claus could you rebase once more, please? I tried, but failed. -
Mathias Schreiber uploaded patch set 16 02/06/18, 22:09
-
TYPO3com voted on patch set 16 V -1 02/06/18, 22:09 Completed build in 10s on Tue, 6 Feb, 11:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19053
-
Mathias Schreiber uploaded patch set 17 02/06/18, 22:10
-
Mathias Schreiber commented on patch set 17 CR -1 02/06/18, 22:12
Rebased to keep the discussion going. What I saw from skimming over it: the deprecation warning should be a regular PHP error and a Deprecation rst is necessary. I can jump into the topic and finalize this if desired. -
TYPO3com voted on patch set 17 V +1 02/06/18, 22:18 Completed build in 08m 16s on Tue, 6 Feb, 11:18 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19054
-
Claus Due commented on patch set 17 02/06/18, 22:55
Thanks Mathias - if you can update, that would be great. I've been a bit overbooked since around the last time I updated this patch. -
Anja Leichsenring uploaded patch set 18 02/08/18, 19:34
-
TYPO3com voted on patch set 18 V -1 02/08/18, 19:34 Completed build in 16s on Thu, 8 Feb, 08:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19159
-
Anja Leichsenring commented on patch set 18 CR -1 02/08/18, 19:35
there are still usages of the deprecated interface in the core. Is the removal scope of this patch, or would you prefer to do that in a second one? -
Anja Leichsenring uploaded patch set 19 02/08/18, 19:37
-
Anja Leichsenring commented on patch set 19 CR -1 02/08/18, 19:38
once more: there are still usages of the deprecated interface in the core. Is the removal scope of this patch, or would you prefer to do that in a second one? -
TYPO3com voted on patch set 19 V +1 02/08/18, 19:48 Completed build in 10m 32s on Thu, 8 Feb, 08:48 PM Test Summary: 30467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19160
-
Claus Due commented on patch set 19 02/08/18, 20:45
Thanks everyone for helping out here. I think it's best if we remove the old interface usages in another patch. If for no other reason then to limit the size of this one. But you decide. I've got some time over the weekend to follow up on this one if needed. -
Anja Leichsenring commented on patch set 19 CR 0 04/14/18, 17:15
> Patch Set 19: > > Thanks everyone for helping out here. > > I think it's best if we remove the old interface usages in another patch. If for no other reason then to limit the size of this one. > > But you decide. I've got some time over the weekend to follow up on this one if needed. I opt for removal. The core should never use deprecated functions. -
Anja Leichsenring uploaded patch set 20 04/14/18, 17:17
-
TYPO3com voted on patch set 20 V +1 04/14/18, 17:25 Completed build in 07m 59s on Sat, 14 Apr, 07:25 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22339
-
Anja Leichsenring commented on patch set 20 CR -1 04/14/18, 17:27
rebased for your convenience. Will leave the -1 in place until the deprecated interface is not in use anymore. -
Wouter Wolters wrote 08/05/18, 21:49
Removed reviewer Wouter Wolters. -
Anja Leichsenring commented on patch set 20 08/10/18, 16:39
> Patch Set 20: Code-Review-1 > > rebased for your convenience. Will leave the -1 in place until the deprecated interface is not in use anymore. ping -
Anja Leichsenring commented on patch set 20 05/19/19, 07:35
> Patch Set 20: > > > Patch Set 20: Code-Review-1 > > > > rebased for your convenience. Will leave the -1 in place until the deprecated interface is not in use anymore. > > ping ping 2nd. Please get any action in here, one way or the other. This patch is idling around since a year. -
Claus Due commented on patch set 20 05/22/19, 21:08
> ping 2nd. Please get any action in here, one way or the other. This patch is idling around since a year. Hi Anja, Please leave open for now, without the expectation to merge it. This topic relates to one of the T3 budgets I currently have - it very much belongs as part of a formal "content type definition" which is one of the tasks in my "crazy experiments" bag. In that context, this feature would probably be delivered from a content type, with a reduced API compared to this (since we'd need no resolver etc.). So I'd like to keep it for reference until further notice. If it still makes sense as a separate feature I will revive it - otherwise, it probably will be assimilated by another feature. Hope that's okay even though this merge request is admittedly getting a bit moldy ;) -
Anja Leichsenring wrote 09/09/19, 08:39
Removed reviewer Anja Leichsenring with the following votes: * Code-Review-1 by Anja Leichsenring <aleichsenring@ab-softlab.de> -
Daniel Siepmann commented on patch set 20 02/19/20, 08:50
StandardContentPreviewRenderer.php:105The old implementation also logged the exception as a warning. Should we keep that behaviour? Sidenote: That's also the place patch 63318 is trying to improve for integrator experience. -
Claus Due commented on patch set 20 02/19/20, 08:52
StandardContentPreviewRenderer.php:105Reply UnresolvedYes, when I come around to this patch again I will update it with the logging - still makes sense to me to log it even if a flash message is shown. -
Claus Due uploaded patch set 21 02/23/20, 14:42
-
TYPO3com voted on patch set 21 V +1 02/23/20, 15:16 Completed build in 29m 26s on Sun, 23 Feb, 03:16 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-565
-
Tymoteusz Motylewski commented on patch set 21 02/24/20, 15:52
StandardContentPreviewRenderer.php:308Unresolvedtypes please, also $str would benefit from a better name. maybe "$linkText" ? -
Claus Due uploaded patch set 22 02/24/20, 19:46
-
TYPO3com voted on patch set 22 V -1 02/24/20, 20:00 Completed build in 13m 14s on Mon, 24 Feb, 08:00 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-649
-
Claus Due uploaded patch set 23 02/24/20, 20:03
-
TYPO3com voted on patch set 23 V +1 02/24/20, 20:38 Completed build in 27m 36s on Mon, 24 Feb, 08:38 PM Test Summary: 71600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-650
-
Claus Due uploaded patch set 24 02/24/20, 20:55
-
Georg Ringer commented on patch set 24 CR -1 02/24/20, 21:07
custom hooks are called but not yet properly checked. we are on it -
Claus Due uploaded patch set 25 02/24/20, 21:16
-
Georg Ringer voted on patch set 25 V +1 CR +1 02/24/20, 21:24
-
Claus Due uploaded patch set 26 02/24/20, 21:35
-
Manuel Selbach voted on patch set 25 V +1 02/24/20, 21:35
-
Georg Ringer voted on patch set 26 V +1 CR +1 02/24/20, 21:36
-
TYPO3com voted on patch set 24 V +1 02/24/20, 21:36 Completed build in 28m 42s on Mon, 24 Feb, 09:36 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-655
-
TYPO3com voted on patch set 25 V +1 02/24/20, 21:42 Completed build in 23m 20s on Mon, 24 Feb, 09:42 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-657
-
Claus Due uploaded patch set 27 02/24/20, 21:49
-
Claus Due uploaded patch set 28 02/24/20, 21:54
-
TYPO3com voted on patch set 26 V +1 02/24/20, 22:02 Completed build in 21m 52s on Mon, 24 Feb, 10:02 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-660
-
TYPO3com voted on patch set 27 V +1 02/24/20, 22:22 Completed build in 17m 33s on Mon, 24 Feb, 10:22 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-662
-
TYPO3com voted on patch set 28 V +1 02/24/20, 22:40 Completed build in 34m 34s on Mon, 24 Feb, 10:40 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-664
-
Claus Due uploaded patch set 29 02/24/20, 22:49
-
Georg Ringer voted on patch set 29 V +1 CR +1 02/24/20, 22:52
-
TYPO3com voted on patch set 29 V +1 02/24/20, 23:05 Completed build in 15m 33s on Mon, 24 Feb, 11:05 PM Test Summary: 71600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-667
-
Manuel Selbach commented on patch set 29 V -1 02/24/20, 23:47
After disabling the feature flag the preview was different -
Susi Moog uploaded patch set 30 02/25/20, 06:24
-
Susi Moog commented on patch set 30 02/25/20, 06:25
the drawItem hook should now behave like the old one. If the hook returns content that is always added. The drawItem switch just distinguishes between additionally rendering the normal preview or not. -
TYPO3com voted on patch set 30 V +1 02/25/20, 06:51 Completed build in 24m 56s on Tue, 25 Feb, 06:51 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-671
-
Claus Due commented on patch set 30 02/25/20, 06:52
I confirm that after Susi's patch, the output and behavior of the PageLayoutView and PreviewRenderer is now identical when calling preview hooks. -
Georg Ringer voted on patch set 30 V +1 CR +1 02/25/20, 06:57
-
Susi Moog voted on patch set 30 V +1 CR +1 02/25/20, 06:58
-
Georg Ringer voted on patch set 30 V +2 CR +2 02/25/20, 06:59
-
Georg Ringer merged patch set 31 02/25/20, 06:59
-
Alexander Schnitzler commented on patch set 31 02/27/20, 16:38
Post -1:StandardContentPreviewRenderer.php:218UnresolvedPost -1: Access to an undefined property TYPO3\CMS\Backend\Preview\StandardContentPreviewRenderer::$record -
Benni Mack commented on patch set 31 03/30/20, 19:57
GridColumnItem.php:73Unresolved-1 This change is incompatible with existing hooks with the old module - a custom module previously used the $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawItem'] hook to alter the $record array which was then put into a Fluid preview. This is pretty common for relations within content elements. With this change, the preview content (line 72) = the fluid template is executed before the actual drawItem hook is called, making it impossible to enrich the data or use the existing logic, so extension authors / content type creators (like common third-party extensions like DCE) need to rework this and add hooks twice now. -
Benni Mack commented on patch set 31 03/30/20, 20:45
This is my bugfix https://review.typo3.org/c/Packages/TYPO3.CMS/+/64020/
StandardPreviewRendererResolver.php:26