Review main Merged

50401[TASK] Acceptance test for Elements Group

Gordon Brüggemann CR +2 V +2 Normal +181 −0 updated 10/27/16, 12:19

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Gohlke +1
    • Marco Bresch +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Gohlke +1
    • Marco Bresch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1115

  1. Gordon Brüggemann uploaded patch set 1 10/27/16, 10:06

  2. Gordon Brüggemann uploaded patch set 2 10/27/16, 10:16

  3. TYPO3com voted on patch set 1 V +1 10/27/16, 10:17 Completed build in 11m 01s on Thu, 27 Oct, 12:17 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4308

  4. TYPO3com voted on patch set 2 V +1 10/27/16, 10:22 Completed build in 05m 23s on Thu, 27 Oct, 12:22 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4310

  5. Marco Bresch commented on patch set 2 CR -1 10/27/16, 11:01

    Found some typos. New patch set coming soon.
  6. Marco Bresch uploaded patch set 3 10/27/16, 11:16

  7. TYPO3com voted on patch set 3 V +1 10/27/16, 11:23 Completed build in 06m 59s on Thu, 27 Oct, 01:23 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4319

  8. Gordon Brüggemann commented on patch set 3 CR +1 V +1 10/27/16, 11:23

    thank you look better
  9. Marco Bresch voted on patch set 3 CR +1 V +1 10/27/16, 11:29

  10. Daniel Gohlke uploaded patch set 4 10/27/16, 12:07

  11. TYPO3com voted on patch set 4 V +1 10/27/16, 12:12 Completed build in 05m 19s on Thu, 27 Oct, 02:12 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4322

  12. Marco Bresch voted on patch set 4 CR +1 V +1 10/27/16, 12:18

  13. Daniel Gohlke voted on patch set 4 CR +1 V +1 10/27/16, 12:18

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 10/27/16, 12:18

  15. Gerrit merged patch set 4 10/27/16, 12:19