50404[TASK] Fluidification of HelpToolbarItem
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Daniel Gohlke +1
- Kevin Appelt +1
- Jan Helke +1
-
Verified V +2
- Anja Leichsenring +2
- Daniel Gohlke +1
- Kevin Appelt +1
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1012
-
Marc Willmann uploaded patch set 1 10/27/16, 12:55
-
TYPO3com voted on patch set 1 V +1 10/27/16, 13:01 Completed build in 05m 09s on Thu, 27 Oct, 03:01 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4329
-
Jan Helke voted on patch set 1 CR +1 V +1 10/27/16, 13:22
-
Kevin Appelt commented on patch set 1 CR -1 V +1 10/27/16, 13:38
HelpToolbarItemDropDown.html:19Can be also removed, cause it has no impact. -
Kevin Appelt commented on patch set 2 10/27/16, 13:41
Published edit on patch set 1. -
Kevin Appelt voted on patch set 2 CR +1 V +1 10/27/16, 13:43
-
TYPO3com voted on patch set 2 V +1 10/27/16, 13:46 Completed build in 05m 24s on Thu, 27 Oct, 03:46 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4335
-
Jan Helke voted on patch set 2 CR +1 V +1 10/27/16, 13:47
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 10/27/16, 13:48
-
Daniel Gohlke commented on patch set 2 CR +1 V +1 10/27/16, 14:04
Looks good to me. Acceptance tests passed. -
Anja Leichsenring voted on patch set 2 CR +2 V +2 10/27/16, 14:05
-
Gerrit merged patch set 2 10/27/16, 14:05
HelpToolbarItemDropDown.html:7