Review main Merged

50410[TASK] Update bower components to latest versions

Frank Nägler CR -1 V +2 Nightmare +3716 −790 updated 10/28/16, 13:58

Commit message

This patch updates the bower components to the latest version.
Also the version contraints in bower.json are updated to get the
latest and non breaking versions.

Only for jquery-ui we pinned the version to 1.11.4 for legacy reasons.

Review

  • Code review CR -1
    • Markus Klein +2
    • Wouter Wolters -1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 1114

  1. Frank Nägler uploaded patch set 1 10/28/16, 11:40

  2. Wouter Wolters commented on patch set 1 CR -1 10/28/16, 11:43

    By updating fontawesome you need to copy the fonts to the right folder.
  3. TYPO3com voted on patch set 1 V +1 10/28/16, 11:45 Completed build in 04m 13s on Fri, 28 Oct, 01:45 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4368

  4. Frank Nägler uploaded patch set 2 10/28/16, 11:53

  5. Frank Nägler uploaded patch set 3 10/28/16, 11:55

  6. Markus Klein voted on patch set 3 CR +1 10/28/16, 11:58

  7. TYPO3com voted on patch set 2 V +1 10/28/16, 11:58 Completed build in 04m 54s on Fri, 28 Oct, 01:58 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4369

  8. TYPO3com voted on patch set 3 V +1 10/28/16, 12:00 Completed build in 05m 23s on Fri, 28 Oct, 02:00 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4370

  9. Markus Klein commented on patch set 3 V +1 10/28/16, 12:09

    Seems to work so far
  10. Wouter Wolters commented on patch set 3 CR +1 V +1 10/28/16, 12:09

    Tested slider, imagecropping feature, datepicker to test timezone. FontAwesome icons are still loaded.
  11. Wouter Wolters commented on patch set 3 CR -1 10/28/16, 12:10

    moment.js:2

    we miss the translation data here now.
  12. Markus Klein voted on patch set 3 CR +2 V +2 10/28/16, 12:11

  13. Gerrit merged patch set 3 10/28/16, 12:11

  14. Wouter Wolters commented on patch set 4 10/28/16, 13:58

    post +1 , browser caches strike again.