Review main Merged

50427[BUGFIX] Prevent installation of incompatible extensions

Nicole Hummel CR +2 V +2 Easy +8 −3 updated 11/02/16, 11:54

Commit message

If an extension is installed, all information are gathered from database.
Here also a check for possible update versions is triggered. In this
check potential dependency updates are marked which get installed during
the underlying extension installation.
This patch prevents gathering TER information during an installation
process to prevent any update information to be registered.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Michael Oehlhof +1
    • Helmut Hummel +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1618

  1. Nicole Hummel uploaded patch set 1 10/28/16, 22:17

  2. TYPO3com voted on patch set 1 V +1 10/28/16, 22:22 Completed build in 04m 59s on Sat, 29 Oct, 12:22 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4388

  3. Andreas Kienast commented on patch set 1 CR +1 10/28/16, 22:24

    Code looks plausible
  4. Helmut Hummel voted on patch set 1 CR +1 V +1 10/28/16, 23:26

  5. Nicole Hummel updated the commit message in patch set 2 10/28/16, 23:58

  6. Nicole Hummel commented on patch set 2 10/28/16, 23:58

    I decided to backport this patch as an important bug fix to 6.2 as well
  7. TYPO3com voted on patch set 2 V +1 10/29/16, 00:02 Completed build in 04m 11s on Sat, 29 Oct, 02:02 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4396

  8. Wouter Wolters voted on patch set 2 CR +1 10/29/16, 09:26

  9. Helmut Hummel voted on patch set 2 CR +1 V +1 10/29/16, 10:24

  10. Christian Kuhn voted on patch set 2 CR +1 V +1 10/29/16, 12:14

  11. Michael Oehlhof voted on patch set 2 CR +1 10/29/16, 19:40

  12. Benni Mack voted on patch set 2 CR +2 V +2 10/29/16, 20:42

  13. Gerrit merged patch set 2 10/29/16, 20:42

  14. Benni Mack commented on patch set 3 10/29/16, 20:43

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 6932cdaee7ac38ac6d26c4f16276374633658ace
  15. Stefan Padberg commented on patch set 3 10/31/16, 09:16

    With the patched system 7.6 I could not observer that adodb is updated to 8.4 automatically. So the patch seems to be successful.
  16. Oliver Hader commented on patch set 3 11/01/16, 10:45

    7.6 backport was here: https://review.typo3.org/50434
  17. Christian Kuhn commented on patch set 3 11/02/16, 10:21

  18. Nicole Hummel commented on patch set 3 11/02/16, 11:54