Review main Merged

50430[BUGFIX] Allow "0" as path segment in ArrayUtility

Helmut Hummel CR +2 V +2 Normal +96 −10 updated 10/29/16, 10:24

Commit message

The empty() checks are too loose when checking for path segments
of an array, as "0" is a valid segment.
Instead we need to check for an empty string in the according places.

Also add a missing string check in getValueByPath.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jörg Bösche +1
    • Oliver Hader +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Jörg Bösche +1
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1825

  1. Helmut Hummel uploaded patch set 1 10/28/16, 23:18

  2. TYPO3com voted on patch set 1 V +1 10/28/16, 23:23 Completed build in 04m 42s on Sat, 29 Oct, 01:23 AM Test Summary: 19573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4392

  3. Helmut Hummel uploaded patch set 2 10/28/16, 23:39

  4. TYPO3com voted on patch set 2 V -1 10/28/16, 23:45 Completed build in 05m 40s on Sat, 29 Oct, 01:45 AM Test Summary: 19575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4394

  5. Helmut Hummel uploaded patch set 3 10/28/16, 23:48

  6. TYPO3com voted on patch set 3 V +1 10/28/16, 23:53 Completed build in 04m 12s on Sat, 29 Oct, 01:53 AM Test Summary: 19575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4395

  7. Nicole Hummel voted on patch set 3 CR +1 V +1 10/28/16, 23:58

  8. Jörg Bösche voted on patch set 3 CR +1 V +1 10/29/16, 00:15

  9. Helmut Hummel uploaded patch set 4 10/29/16, 00:21

  10. Helmut Hummel uploaded patch set 5 10/29/16, 00:23

  11. TYPO3com voted on patch set 4 V -1 10/29/16, 00:27 Completed build in 05m 16s on Sat, 29 Oct, 02:27 AM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4397

  12. TYPO3com voted on patch set 5 V -1 10/29/16, 00:28 Completed build in 04m 44s on Sat, 29 Oct, 02:28 AM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4398

  13. Helmut Hummel uploaded patch set 6 10/29/16, 00:32

  14. TYPO3com voted on patch set 6 V +1 10/29/16, 00:36 Completed build in 03m 54s on Sat, 29 Oct, 02:36 AM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4400

  15. Nicole Hummel voted on patch set 6 CR +1 V +1 10/29/16, 00:37

  16. Jörg Bösche voted on patch set 6 CR +1 V +1 10/29/16, 00:38

  17. Josef Glatz updated the commit message in patch set 7 10/29/16, 04:23

  18. TYPO3com voted on patch set 7 V +1 10/29/16, 04:29 Completed build in 06m 07s on Sat, 29 Oct, 06:29 AM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4402

  19. Oliver Hader voted on patch set 7 CR +1 10/29/16, 07:19

  20. Jörg Bösche voted on patch set 7 CR +1 V +1 10/29/16, 08:54

  21. Nicole Hummel voted on patch set 7 CR +1 V +1 10/29/16, 09:30

  22. Christian Kuhn voted on patch set 7 CR +2 V +2 10/29/16, 09:40

  23. Gerrit merged patch set 7 10/29/16, 09:40

  24. Christian Kuhn commented on patch set 8 10/29/16, 09:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 87a7031b72e0163a5dbacff41d96b4232ebf30c1
  25. Helmut Hummel commented on patch set 8 10/29/16, 10:24

    Thanks for the quick reviews and merge!