Review main Merged Breaking

50438[!!!][TASK] Migrate OrphanRecords Command to Symfony Console

Benni Mack CR +2 V +2 Hard +339 −159 updated 11/05/16, 09:25

Commit message

The CLI cleaner command "orphan_records" in EXT:lowlevel is
migrated to a command based on Symfony Console.

Previoulsy it was called via
typo3/cli_dispatch.phpsh lowlevel_cleaner orphan_records -s -r

Now you use
typo3/sysext/core/bin/typo3 cleanup:orphanrecords
(optional via --dry-run)

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1117

  1. Benni Mack uploaded patch set 1 10/29/16, 21:37

  2. TYPO3com voted on patch set 1 V -1 10/29/16, 21:42 Completed build in 04m 00s on Sat, 29 Oct, 11:42 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4416

  3. Benni Mack uploaded patch set 2 10/31/16, 05:50

  4. TYPO3com voted on patch set 2 V +1 10/31/16, 05:54 Completed build in 03m 59s on Mon, 31 Oct, 06:54 AM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4456

  5. Benni Mack uploaded patch set 3 10/31/16, 19:30

  6. TYPO3com voted on patch set 3 V -1 10/31/16, 19:38 Completed build in 07m 11s on Mon, 31 Oct, 08:38 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4485

  7. Benni Mack commented on patch set 4 10/31/16, 19:47

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 4 V -1 10/31/16, 19:59 Completed build in 11m 55s on Mon, 31 Oct, 08:59 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4492

  9. Benni Mack uploaded patch set 5 10/31/16, 21:48

  10. TYPO3com voted on patch set 5 V +1 10/31/16, 21:54 Completed build in 06m 14s on Mon, 31 Oct, 10:54 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4510

  11. Wouter Wolters commented on patch set 5 11/01/16, 10:33

    OrphanRecordsCommand.php:64

    this comment is from the DeletedRecordsCommand command.

    OrphanRecordsCommand.php:138

    I opt for: No orphan records found.
  12. Benni Mack commented on patch set 6 11/02/16, 05:55

    Published edit on patch set 5.
  13. TYPO3com voted on patch set 6 V +1 11/02/16, 06:00 Completed build in 05m 05s on Wed, 2 Nov, 07:00 AM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4548

  14. Wouter Wolters voted on patch set 6 CR +1 11/02/16, 07:46

  15. Wouter Wolters voted on patch set 6 V +1 11/03/16, 17:45

  16. Anja Leichsenring voted on patch set 6 CR +2 V +2 11/05/16, 09:25

  17. Gerrit merged patch set 6 11/05/16, 09:25