Review main Merged

50439[BUGFIX] Prevent adding a backend user without password

Michael Oehlhof CR +2 V +2 Easy +1 −1 updated 10/31/16, 14:33

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Jörg Bösche +1
    • Nicole Hummel +1
    • Michael Oehlhof +1
  • Verified V +2
    • Christian Kuhn +2
    • Jörg Bösche +1
    • Nicole Hummel +1
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1719

  1. Michael Oehlhof uploaded patch set 1 10/29/16, 22:14

  2. TYPO3com voted on patch set 1 V +1 10/29/16, 22:19 Completed build in 04m 47s on Sun, 30 Oct, 12:19 AM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4419

  3. Josef Glatz commented on patch set 1 CR +1 V +1 10/30/16, 07:13

    It seems the problem is fixed with this patch so far
  4. Jörg Bösche voted on patch set 1 CR +1 V +1 10/30/16, 20:18

  5. Daniel Gohlke voted on patch set 1 CR +1 V +1 10/30/16, 20:57

  6. Markus Klein commented on patch set 1 10/31/16, 02:25

    This change seems rather dangerous. There was for sure a good reason to add the asterisks here. Please dig into the past and find the reason. Is this also an issue on 7.6?
  7. Nicole Hummel commented on patch set 1 CR -1 10/31/16, 08:36

    I'm on it
  8. Nicole Hummel commented on patch set 1 10/31/16, 08:40

    The current patch prevents backend users from being changed as it clears their password
  9. Nicole Hummel uploaded patch set 2 10/31/16, 08:49

  10. Nicole Hummel voted on patch set 2 CR +1 V +1 10/31/16, 08:50

  11. Nicole Hummel commented on patch set 2 10/31/16, 08:51

    Btw: there were some changes in the JS part which breaks this in the mean time.
  12. TYPO3com voted on patch set 2 V +1 10/31/16, 08:54 Completed build in 04m 36s on Mon, 31 Oct, 09:54 AM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4458

  13. Michael Oehlhof voted on patch set 2 CR +1 V +1 10/31/16, 09:44

  14. Jörg Bösche voted on patch set 2 CR +1 V +1 10/31/16, 10:13

  15. Markus Klein commented on patch set 2 CR +1 10/31/16, 14:16

    Thanks for checking
  16. Christian Kuhn voted on patch set 2 CR +2 V +2 10/31/16, 14:33

  17. Gerrit merged patch set 2 10/31/16, 14:33

  18. Christian Kuhn commented on patch set 3 10/31/16, 14:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 42202fe311e96e87ccaa9ee9c857e17d53d27abf