Review main Merged

50441[BUGFIX] Enable curl on AppVeyor CI

Wouter Wolters CR +2 V +2 Easy +1 −0 updated 10/30/16, 19:03

Commit message

Facebook Webdriver dependency needs curl enabled.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Gohlke +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Wouter Wolters uploaded patch set 1 10/30/16, 18:19

  2. Wouter Wolters commented on patch set 2 10/30/16, 18:22

    Published edit on patch set 1.
  3. TYPO3com voted on patch set 1 V +1 10/30/16, 18:24 Completed build in 04m 35s on Sun, 30 Oct, 07:24 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4434

  4. TYPO3com voted on patch set 2 V +1 10/30/16, 18:26 Completed build in 04m 47s on Sun, 30 Oct, 07:26 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4435

  5. Daniel Gohlke commented on patch set 2 CR +1 10/30/16, 18:48

    Can you add a notice to forge why you want to enable curl?
  6. Wouter Wolters uploaded patch set 3 10/30/16, 18:51

  7. TYPO3com voted on patch set 3 V +1 10/30/16, 18:54 Completed build in 03m 39s on Sun, 30 Oct, 07:54 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4436

  8. Christian Kuhn commented on patch set 3 CR +1 10/30/16, 18:55

    i'd say let's just merge that and see what happens.
  9. Andreas Kienast voted on patch set 3 CR +1 10/30/16, 18:57

  10. Daniel Gohlke voted on patch set 3 CR +1 10/30/16, 19:00

  11. Andreas Kienast commented on patch set 3 CR +2 V +2 10/30/16, 19:03

    Direct merge to see the impact of this patch
  12. Gerrit merged patch set 3 10/30/16, 19:03