Review main Merged

50460[FEATURE] Option to define ordering of suggest wizard results

Markus Klein CR +2 V +2 Normal +51 −41 updated 11/18/16, 21:38

Commit message

This allows to configure the ordering cirteria for suggest wizard search results.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1929

Show 24 earlier messages
  1. Markus Klein uploaded patch set 1 10/31/16, 19:45

  2. Markus Klein uploaded patch set 2 10/31/16, 19:50

  3. TYPO3com voted on patch set 1 V +1 10/31/16, 19:57 Completed build in 11m 49s on Mon, 31 Oct, 08:57 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4491

  4. TYPO3com voted on patch set 2 V +1 10/31/16, 20:00 Completed build in 09m 32s on Mon, 31 Oct, 09:00 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4493

  1. Markus Klein uploaded patch set 3 10/31/16, 20:35

  2. Markus Klein updated the commit message in patch set 4 10/31/16, 20:41

  3. TYPO3com voted on patch set 3 V +1 10/31/16, 20:43 Completed build in 08m 31s on Mon, 31 Oct, 09:43 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4498

  4. TYPO3com voted on patch set 4 V +1 10/31/16, 20:46 Completed build in 04m 35s on Mon, 31 Oct, 09:46 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4500

  5. Markus Klein rebased onto patch set 5 11/12/16, 11:34

  6. Markus Klein uploaded patch set 6 11/12/16, 11:39

  7. Markus Klein uploaded patch set 7 11/12/16, 11:40

  8. TYPO3com voted on patch set 5 V +1 11/12/16, 11:43 Completed build in 08m 59s on Sat, 12 Nov, 12:43 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4844

  9. TYPO3com voted on patch set 6 V -1 11/12/16, 11:51 Completed build in 12m 04s on Sat, 12 Nov, 12:51 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4845

  10. TYPO3com voted on patch set 7 V -1 11/12/16, 11:58 Completed build in 17m 21s on Sat, 12 Nov, 12:58 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4846

  11. Markus Klein uploaded patch set 8 11/12/16, 12:10

  12. TYPO3com voted on patch set 8 V -1 11/12/16, 12:22 Completed build in 11m 26s on Sat, 12 Nov, 01:22 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4847

  13. Markus Klein uploaded patch set 9 11/12/16, 13:17

  14. TYPO3com voted on patch set 9 V +1 11/12/16, 13:31 Completed build in 13m 44s on Sat, 12 Nov, 02:31 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4852

  15. Wouter Wolters voted on patch set 9 CR +1 11/17/16, 18:52

  16. Christian Kuhn commented on patch set 9 CR +1 11/18/16, 20:43

    SuggestWizard.php:265

    clever.

    SuggestWizardDefaultReceiver.php:302

    this is ok since label is a mandatory ctrl field for every TCA table.

    SuggestWizardDefaultReceiver.php:304

    Ok, long term goal is to get rid of the QueryHelper stuff, probably, so i'm not a really major huge fan of implementing that here again. But, there is no current plan for a substitution yet, so this one here turns into "just another usage" then. Thus: fine with me.
  17. Christian Kuhn commented on patch set 9 V +1 11/18/16, 20:50

    looks good to me. tested with tx_styleguide_elements_group in flex_1 flex form, adding to group_db_1 in the wizard suggest section: <default> <orderBy>uid DESC</orderBy> </default>
  18. Claus Due voted on patch set 9 CR +1 11/18/16, 20:52

  19. Andreas Kienast commented on patch set 10 11/18/16, 20:53

    Published edit on patch set 9.
  20. Andreas Kienast commented on patch set 9 11/18/16, 20:56

    SuggestWizardDefaultReceiver.php:304 Reply

    Can't we "simply" introduce an array structure here then, if that setting is new anyway?
  21. TYPO3com voted on patch set 10 V +1 11/18/16, 20:58 Completed build in 05m 04s on Fri, 18 Nov, 09:58 PM Test Summary: 55307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5004

  22. Christian Kuhn commented on patch set 9 11/18/16, 21:03

    SuggestWizardDefaultReceiver.php:304 Reply

    mmh. i'd rather keep that for now and "maybe" later switch all tca occurences at once. it is then at least in sync with all others for now. problem is more that this also pops up in TS frequently, and we have no sane way to migrate that stuff in a sane way at the moment.
  23. Christian Kuhn voted on patch set 10 CR +1 V +1 11/18/16, 21:03

  24. Andreas Kienast voted on patch set 10 CR +2 V +2 11/18/16, 21:38

  25. Gerrit merged patch set 10 11/18/16, 21:38