Review main Merged

50462[TASK] Remove leftover page/branch versioning code

Benni Mack CR +2 V +2 Hard +182 −151 updated 11/01/16, 12:50

Commit message

There are several places within EXT:version and DataHandler
which try to do "pageVersionizing" but it's not possible
anymore (see removed code in "new" section of DataHandlerHook)
since TYPO3 v7.

This also means that the `versioning_followPages` option is removed
completely from the Core.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 1623

  1. Benni Mack uploaded patch set 1 10/31/16, 20:09

  2. TYPO3com voted on patch set 1 V +1 10/31/16, 20:14 Completed build in 05m 15s on Mon, 31 Oct, 09:14 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4494

  3. Oliver Hader commented on patch set 1 CR -1 10/31/16, 20:18

    DataHandlerHook.php:782

    versioning_followPages might still be used - at least we should add a breaking RST

    DataHandlerHook.php:799

    This call is missing then... need to check side-effects

    DataHandlerHook.php:1626

    Find to remove this, does not make much sense how it was used currently
  4. Oliver Hader commented on patch set 1 CR 0 10/31/16, 20:25

    Forget my remarks on DataHandlerHook - that's only valid if tree-levels is greater than -1, which is *never*
  5. Benni Mack uploaded patch set 2 10/31/16, 20:30

  6. TYPO3com voted on patch set 2 V +1 10/31/16, 20:35 Completed build in 04m 53s on Mon, 31 Oct, 09:35 PM Test Summary: 54741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4497

  7. Benni Mack uploaded patch set 3 10/31/16, 20:51

  8. TYPO3com voted on patch set 3 V -1 10/31/16, 21:03 Completed build in 11m 12s on Mon, 31 Oct, 10:03 PM Test Summary: 54765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4504

  9. Benni Mack uploaded patch set 4 10/31/16, 21:28

  10. TYPO3com voted on patch set 4 V -1 10/31/16, 21:33 Completed build in 05m 12s on Mon, 31 Oct, 10:33 PM Test Summary: 54765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4508

  11. Benni Mack uploaded patch set 5 10/31/16, 21:37

  12. TYPO3com voted on patch set 5 V +1 10/31/16, 21:41 Completed build in 03m 49s on Mon, 31 Oct, 10:41 PM Test Summary: 54765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4509

  13. Wouter Wolters commented on patch set 5 11/01/16, 07:49

    TcaMigrationTest.php:1686

    Don't you want to add a new test here instead of replacing a test? If so the name of the test itself is wrong ;-)
  14. Christian Kuhn voted on patch set 5 CR -1 11/01/16, 12:20

  15. Christian Kuhn commented on patch set 5 11/01/16, 12:20

    on it.
  16. Christian Kuhn uploaded patch set 6 11/01/16, 12:27

  17. Christian Kuhn commented on patch set 5 11/01/16, 12:27

    TcaMigrationTest.php:1686 Reply

    Done
  18. TYPO3com voted on patch set 6 V +1 11/01/16, 12:31 Completed build in 04m 06s on Tue, 1 Nov, 01:31 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4528

  19. Christian Kuhn uploaded patch set 7 11/01/16, 12:37

  20. TYPO3com voted on patch set 7 V +1 11/01/16, 12:44 Completed build in 12m 25s on Tue, 1 Nov, 01:44 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4530

  21. Christian Kuhn voted on patch set 7 CR +1 V +1 11/01/16, 12:45

  22. Wouter Wolters voted on patch set 7 CR +2 V +2 11/01/16, 12:50

  23. Gerrit merged patch set 7 11/01/16, 12:50