Review TYPO3_7-6 Merged

50489[BUGFIX] Provide addQueryStringMethod for ViewHelper f:form

Georg Ringer CR +2 V +2 Easy +22 −2 updated 11/13/16, 08:48

Commit message

Make it possible to set the addQueryStringMethod for the f:form
ViewHelper. Otherwise it is impossible to add parameters resolved
by realurl. This has been fixed in master already.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jörg Bösche +1
    • Oliver Hader +1
  • Verified V +2
    • Markus Klein +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Georg Ringer uploaded patch set 1 11/03/16, 07:35

  2. TYPO3com voted on patch set 1 V +1 11/03/16, 07:39 Completed build in 03m 54s on Thu, 3 Nov, 08:39 AM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-314

  3. Claus Due commented on patch set 1 CR -1 11/03/16, 18:38

    FormViewHelper.php:150

    The default value should be "GET" if we wish to match https://review.typo3.org/#/c/49642/5/typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php (from the corresponding patch to master). Other than that: looks good!
  4. Georg Ringer commented on patch set 1 11/04/16, 20:07

    but then it would be a breaking change. I would be in favor as well for GET but there is no way to change that in 7
  5. Claus Due commented on patch set 1 CR +1 11/04/16, 20:10

    I wasn't aware that would be breaking. If an empty string is as good (I assume you tested) then no problem from me - in that case: looks good :)
  6. Jörg Bösche voted on patch set 1 CR +1 11/09/16, 18:35

  7. Oliver Hader commented on patch set 2 11/09/16, 21:54

    Published edit on patch set 1.
  8. Oliver Hader voted on patch set 2 CR +1 11/09/16, 21:54

  9. TYPO3com voted on patch set 2 V +1 11/09/16, 22:04 Completed build in 09m 29s on Wed, 9 Nov, 11:04 PM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-342

  10. Markus Klein voted on patch set 2 CR +1 V +1 11/12/16, 17:20

  11. Jörg Bösche voted on patch set 2 CR +1 V +1 11/12/16, 23:43

  12. Markus Klein voted on patch set 2 CR +2 V +2 11/13/16, 08:48

  13. Gerrit merged patch set 2 11/13/16, 08:48