50489[BUGFIX] Provide addQueryStringMethod for ViewHelper f:form
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Jörg Bösche +1
- Oliver Hader +1
-
Verified V +2
- Markus Klein +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Georg Ringer uploaded patch set 1 11/03/16, 07:35
-
TYPO3com voted on patch set 1 V +1 11/03/16, 07:39 Completed build in 03m 54s on Thu, 3 Nov, 08:39 AM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-314
-
Claus Due commented on patch set 1 CR -1 11/03/16, 18:38
-
Georg Ringer commented on patch set 1 11/04/16, 20:07
but then it would be a breaking change. I would be in favor as well for GET but there is no way to change that in 7 -
Claus Due commented on patch set 1 CR +1 11/04/16, 20:10
I wasn't aware that would be breaking. If an empty string is as good (I assume you tested) then no problem from me - in that case: looks good :) -
Jörg Bösche voted on patch set 1 CR +1 11/09/16, 18:35
-
Oliver Hader commented on patch set 2 11/09/16, 21:54
Published edit on patch set 1. -
Oliver Hader voted on patch set 2 CR +1 11/09/16, 21:54
-
TYPO3com voted on patch set 2 V +1 11/09/16, 22:04 Completed build in 09m 29s on Wed, 9 Nov, 11:04 PM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-342
-
Markus Klein voted on patch set 2 CR +1 V +1 11/12/16, 17:20
-
Jörg Bösche voted on patch set 2 CR +1 V +1 11/12/16, 23:43
-
Markus Klein voted on patch set 2 CR +2 V +2 11/13/16, 08:48
-
Gerrit merged patch set 2 11/13/16, 08:48
FormViewHelper.php:150