Review main Merged

50506[TASK] Close document by clicking "Save and create new one"

Markus Hölzle CR +2 V +2 Normal +34 −17 updated 11/12/16, 17:22

Commit message

Close the current document in 'Open documents' list by
clicking the "Save and create a new one" button.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jörg Bösche +1
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1923

  1. Markus Hölzle uploaded patch set 1 11/05/16, 11:33

  2. TYPO3com voted on patch set 1 V +1 11/05/16, 11:38 Completed build in 04m 23s on Sat, 5 Nov, 12:38 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4606

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 11/05/16, 14:37

  4. Anja Leichsenring updated the commit message in patch set 2 11/05/16, 14:38

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 11/05/16, 14:38

  6. Markus Klein commented on patch set 2 11/05/16, 14:44

    Bug in 7.6 as well?
  7. TYPO3com voted on patch set 2 V +1 11/05/16, 14:47 Completed build in 08m 20s on Sat, 5 Nov, 03:47 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4616

  8. Frank Nägler commented on patch set 2 CR -1 11/07/16, 10:33

    on it
  9. Frank Nägler uploaded patch set 3 11/07/16, 10:57

  10. Frank Nägler commented on patch set 3 11/07/16, 10:59

    I have added constants to optimize the readability. The method should be refactored, and implemented in a new way. but imho not within in this patch.
  11. TYPO3com voted on patch set 3 V +1 11/07/16, 11:02 Completed build in 04m 48s on Mon, 7 Nov, 12:02 PM Test Summary: 54863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4659

  12. Markus Hölzle commented on patch set 3 CR +1 11/07/16, 12:17

    Looks good for the moment, but I think we should fix it also for 7.6 (see forge)
  13. Frank Nägler updated the commit message in patch set 4 11/07/16, 13:33

  14. TYPO3com voted on patch set 4 V +1 11/07/16, 13:37 Completed build in 04m 13s on Mon, 7 Nov, 02:37 PM Test Summary: 54863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4670

  15. Markus Klein commented on patch set 4 11/07/16, 16:35

    EditDocumentController.php:480

    isn't that already an int here?

    EditDocumentController.php:702

    same here
  16. Frank Nägler commented on patch set 4 11/08/16, 13:50

    EditDocumentController.php:480 Reply

    closeDoc is a public property :/ we can't guarantee that it is alway an int
  17. Frank Nägler commented on patch set 4 11/08/16, 13:51

    @Markus: as mentioned in the other comment, this part needs a refactoring, but not within this patch.
  18. Markus Klein commented on patch set 4 CR +1 11/08/16, 14:20

    good then, thanks, overlooked that public thingy
  19. Michael Oehlhof voted on patch set 4 CR +1 V +1 11/09/16, 09:23

  20. Jörg Bösche voted on patch set 4 CR +1 11/09/16, 18:32

  21. Markus Klein voted on patch set 4 CR +2 V +2 11/12/16, 17:22

  22. Gerrit merged patch set 4 11/12/16, 17:22

  23. Markus Klein commented on patch set 5 11/12/16, 17:22

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit a8343e8cd47cc2c142ea7c1f72016f061df8813b