Review main Merged

50512[FOLLOWUP][TASK] Fluidification of Opendocs Toolbar (2nd try)

Andreas Kienast CR +2 V +2 Easy +4 −1 updated 11/05/16, 18:51

Commit message

`list($x, )` does not work on empty arrays, causing `$x` being null then.
The code now checks whether there are actually open docs and then does
the list() stuff.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Andreas Kienast uploaded patch set 1 11/05/16, 18:08

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 11/05/16, 18:09

  3. TYPO3com voted on patch set 1 V +1 11/05/16, 18:14 Completed build in 05m 57s on Sat, 5 Nov, 07:14 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4637

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 11/05/16, 18:51

  5. Gerrit merged patch set 1 11/05/16, 18:51