Review main Merged

50514[TASK] Remove duplicate calls to substr in InfoPageTyposcriptConfigController

Wouter Wolters CR +2 V +2 Easy +5 −5 updated 11/07/16, 09:52

Commit message

substr is called 3 times with the same parameters, use one variable for this.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Andreas Kienast +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Wouter Wolters uploaded patch set 1 11/06/16, 16:14

  2. TYPO3com voted on patch set 1 V +1 11/06/16, 16:19 Completed build in 04m 54s on Sun, 6 Nov, 05:19 PM Test Summary: 54863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4649

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/07/16, 09:44

  4. Tymoteusz Motylewski voted on patch set 1 CR +2 V +2 11/07/16, 09:52

  5. Gerrit merged patch set 1 11/07/16, 09:52