Review main Merged

50516[BUGFIX] EM must treat line breaks correctly in extension data

Markus Klein CR +2 V +2 Easy +9 −8 updated 11/13/16, 09:33

Commit message

The XML push-parser now correctly collects the data for
description and upload comment. When the data contain line breaks
the characterData() method is called multiple times
for each line of data.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Nicole Hummel +1
  • Verified V +2
    • Stefan Neufeind +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1317

  1. Markus Klein uploaded patch set 1 11/07/16, 00:38

  2. TYPO3com voted on patch set 1 V +1 11/07/16, 00:43 Completed build in 04m 01s on Mon, 7 Nov, 01:43 AM Test Summary: 54863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4652

  3. Markus Klein updated the commit message in patch set 2 11/07/16, 00:44

  4. TYPO3com voted on patch set 2 V +1 11/07/16, 00:48 Completed build in 04m 01s on Mon, 7 Nov, 01:48 AM Test Summary: 54863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4653

  5. Wouter Wolters voted on patch set 2 CR +1 11/07/16, 08:18

  6. Nicole Hummel commented on patch set 2 11/07/16, 11:22

    DownloadController.php:342

    IMHO this is escaping at the wrong place. The action generates json and sends it back to the browser. I would prefer to enforce the <br> tags in JS or CSS (white-space: pre-line;)
  7. Markus Klein commented on patch set 2 11/07/16, 16:15

    DownloadController.php:342 Reply

    Thought about that too, but decided that the output is specific for HTML anyway, hence I decided to do that in PHP. But I'm fine with any solution.
  8. Markus Klein uploaded patch set 3 11/11/16, 23:42

  9. TYPO3com voted on patch set 3 V +1 11/11/16, 23:53 Completed build in 10m 16s on Sat, 12 Nov, 12:53 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4836

  10. Stefan Neufeind voted on patch set 3 CR +1 V +1 11/12/16, 17:46

  11. Nicole Hummel commented on patch set 3 CR -1 11/12/16, 22:35

    On it
  12. Nicole Hummel uploaded patch set 4 11/12/16, 23:08

  13. Nicole Hummel commented on patch set 4 CR +1 V +1 11/12/16, 23:08

    We do not want support multi line within the author data.
  14. TYPO3com voted on patch set 4 V +1 11/12/16, 23:19 Completed build in 10m 38s on Sun, 13 Nov, 12:19 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4872

  15. Stefan Neufeind voted on patch set 4 CR +2 V +2 11/13/16, 09:33

  16. Gerrit merged patch set 4 11/13/16, 09:33

  17. Stefan Neufeind commented on patch set 5 11/13/16, 09:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 669756958cca03f20fc0eefac5616cf5f73c192a