Review main Merged

50525[BUGFIX] Resolves editing problem in language mode

Markus Sommer CR +2 V +2 Easy +4 −4 updated 12/02/16, 11:01

Commit message

* Resolves the problem with many languages
* Set width to min-width to enlarge the viewport

Review

  • Code review CR +2
    • Jan Helke +2
    • Manuel Glauser +1
    • Gianluigi Martino +1
  • Verified V +2
    • Jan Helke +2
    • Manuel Glauser +1
    • Gianluigi Martino +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Markus Sommer uploaded patch set 1 11/07/16, 15:02

  2. TYPO3com voted on patch set 1 V +1 11/07/16, 15:07 Completed build in 04m 30s on Mon, 7 Nov, 04:07 PM Test Summary: 54863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4675

  3. Markus Biberger commented on patch set 1 CR -1 11/10/16, 07:46

    _module_web_page.less:40

    min width is not enough, you need table-layout: auto to fix this.
  4. Markus Sommer commented on patch set 1 12/01/16, 14:00

    _module_web_page.less:40 Reply

    This is the correct way. The Problem is not the core the problem come with gridelements. If you wont to use element in element in element you need a special CSS for this.
  5. Gianluigi Martino voted on patch set 1 CR +1 V +1 12/01/16, 14:06

  6. Manuel Glauser voted on patch set 1 CR +1 V +1 12/01/16, 14:13

  7. Tymoteusz Motylewski commented on patch set 1 12/01/16, 15:29

    can you improve the commit message to state what is changed and how?
  8. Markus Sommer updated the commit message in patch set 2 12/02/16, 08:54

  9. Manuel Glauser voted on patch set 2 CR +1 V +1 12/02/16, 08:56

  10. Gianluigi Martino voted on patch set 2 CR +1 V +1 12/02/16, 08:56

  11. TYPO3com voted on patch set 2 V +1 12/02/16, 08:59 Completed build in 04m 48s on Fri, 2 Dec, 09:59 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5307

  12. Jan Helke voted on patch set 2 CR +1 V +1 12/02/16, 10:56

  13. Jan Helke voted on patch set 2 CR +2 V +2 12/02/16, 11:00

  14. Gerrit merged patch set 2 12/02/16, 11:01