Review TYPO3_7-6 Abandoned

50530[BUGFIX] Flush all cache tags in bulk when deleting records

Claus Due CR 0 V 0 Easy +36 −12 updated 11/27/16, 01:23

Commit message

This patch makes the TYPO3 DB cache backend capable of
flushing tags using an array of tag names that is then turned
into a CSV list and used in an `IN` query. It limits the number
of cache flushes from $numRecords to 1.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1825

  1. Claus Due uploaded patch set 1 11/07/16, 16:10

  2. Claus Due uploaded patch set 2 11/07/16, 16:11

  3. TYPO3com voted on patch set 1 V -1 11/07/16, 16:14 Completed build in 03m 34s on Mon, 7 Nov, 05:14 PM Test Summary: 2504 of 38082 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-330

  4. TYPO3com voted on patch set 2 V -1 11/07/16, 16:16 Completed build in 04m 25s on Mon, 7 Nov, 05:16 PM Test Summary: 2504 of 38082 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-331

  5. Claus Due uploaded patch set 3 11/07/16, 16:24

  6. TYPO3com voted on patch set 3 V -1 11/07/16, 16:27 Completed build in 02m 44s on Mon, 7 Nov, 05:27 PM Test Summary: 2504 of 38082 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-332

  7. Christian Kuhn commented on patch set 3 11/07/16, 18:04

    what about master?
  8. Claus Due commented on patch set 2 11/07/16, 18:05

    I think master needs a slightly different fix - I'm checking that part after dinner.
  9. Claus Due uploaded patch set 4 11/07/16, 18:16

  10. Claus Due commented on patch set 2 11/07/16, 18:16

    This should fix the tests and remaining issues with code.
  11. TYPO3com voted on patch set 4 V -1 11/07/16, 18:20 Completed build in 04m 08s on Mon, 7 Nov, 07:20 PM Test Summary: 2466 of 38082 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-333

  12. Claus Due uploaded patch set 5 11/07/16, 18:24

  13. TYPO3com voted on patch set 5 V +1 11/07/16, 18:28 Completed build in 03m 48s on Mon, 7 Nov, 07:28 PM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-334

  14. Claus Due commented on patch set 5 11/07/16, 23:46

    Counterpart patch for master is at https://review.typo3.org/#/c/50537/ - required a bit more work on the tests to get that one done.
  15. Stephan Großberndt commented on patch set 5 11/08/16, 10:22

    Typo3DatabaseBackend.php:294

    You imploded the $tagList above to a string, did you want to count the string length or the number of array items?
  16. Claus Due uploaded patch set 6 11/08/16, 10:48

  17. Claus Due commented on patch set 6 11/08/16, 10:49

    Thanks for the catch Stephan
  18. TYPO3com voted on patch set 6 V +1 11/08/16, 10:55 Completed build in 06m 31s on Tue, 8 Nov, 11:55 AM Test Summary: 38082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-338

  19. Markus Klein commented on patch set 6 11/09/16, 22:07

    Shouldn't this have the same change id as the master patch??
  20. Markus Klein voted on patch set 6 CR -1 11/09/16, 22:07

  21. Claus Due commented on patch set 6 11/09/16, 23:03

    If I give it the same change-id it will upload the changes in one issue to the other as well. So no, I don't think so?
  22. Claus Due wrote 11/15/16, 15:56

    Topic changed from issues/78596 to performance
  23. Claus Due uploaded patch set 7 11/19/16, 19:29

  24. TYPO3com voted on patch set 7 V +1 11/19/16, 19:35 Completed build in 05m 09s on Sat, 19 Nov, 08:35 PM Test Summary: 38086 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-415

  25. Claus Due abandoned the change 11/27/16, 01:23

    Replaced by https://review.typo3.org/#/c/50785/ which is a true cherry-pick of the same change for master, in the most recent version.