50534[TASK] Replace beginsWith method with strpos to reduce execution time
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Markus Klein +1
-
Verified V +2
- Frank Nägler +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 33
- typo3/sysext/backend/Classes/Console/CliRequestHandler.php+1 −2
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+2 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessPlaceholders.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+2 −3
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizard.php+1 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −2
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+5 −6
- typo3/sysext/core/Classes/Hooks/BackendUserGroupIntegrityCheck.php+1 −2
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+1 −2
- typo3/sysext/core/Classes/Imaging/IconProvider/BitmapIconProvider.php+2 −3
- typo3/sysext/core/Classes/Imaging/IconProvider/SvgIconProvider.php+2 −3
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+4 −5
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+1 −2
- typo3/sysext/core/Classes/Tests/UnitTestCase.php+1 −2
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+2 −3
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+3 −4
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/PathUtility.php+1 −1
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+2 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+5 −5
Show 13 more files
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −2
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −2
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck.php+2 −3
- typo3/sysext/install/Classes/Updates/DatabaseCharsetUpdate.php1+2 −3
- typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php+2 −3
- typo3/sysext/linkvalidator/Classes/Linktype/FileLinktype.php+1 −2
- typo3/sysext/linkvalidator/Classes/Linktype/LinkHandler.php+1 −2
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+2 −3
- typo3/sysext/rsaauth/Classes/RsaEncryptionDecoder.php+1 −3
- typo3/sysext/rtehtmlarea/Classes/Hook/Install/DeprecatedRteProperties.php+1 −2
- typo3/sysext/rtehtmlarea/Classes/Hook/Install/RteAcronymButtonRenamedToAbbreviation.php+1 −2
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+1 −2
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableTask.php+1 −2
Review log 1216
-
Wouter Wolters uploaded patch set 1 11/07/16, 20:25
-
TYPO3com voted on patch set 1 V -1 11/07/16, 20:29 Completed build in 04m 31s on Mon, 7 Nov, 09:29 PM Test Summary: 55235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4687
-
Wouter Wolters uploaded patch set 2 11/07/16, 21:16
-
TYPO3com voted on patch set 2 V +1 11/07/16, 21:20 Completed build in 03m 49s on Mon, 7 Nov, 10:20 PM Test Summary: 55235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4691
-
Wouter Wolters updated the commit message in patch set 3 11/07/16, 21:27
-
TYPO3com voted on patch set 3 V +1 11/07/16, 21:31 Completed build in 03m 42s on Mon, 7 Nov, 10:31 PM Test Summary: 55235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4693
-
Susi Moog voted on patch set 3 CR +1 11/08/16, 09:09
-
Christian Kuhn commented on patch set 3 CR -1 11/08/16, 09:52
-
Markus Klein commented on patch set 3 11/08/16, 10:12
Are you sure it is safe to change that everywhere? beginsWith() does way more than just comparing strings! -
Markus Klein uploaded patch set 4 11/08/16, 10:25
-
Markus Klein commented on patch set 4 CR +1 V +1 11/08/16, 10:27
Works as far as I tested. All conversions should be correct, I hope I didn't overlook a mistake. -
TYPO3com voted on patch set 4 V +1 11/08/16, 10:32 Completed build in 06m 43s on Tue, 8 Nov, 11:32 AM Test Summary: 55247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4700
-
Wouter Wolters commented on patch set 4 11/08/16, 10:43
@markus I did not replace this automatically but had a close look in every situation. AFAICS there shouldn't be a problem but I suggest to have some more eyes on this one here. -
Frank Nägler voted on patch set 4 CR +1 11/08/16, 11:22
-
Frank Nägler voted on patch set 4 CR +2 V +2 11/08/16, 11:58
-
Gerrit merged patch set 4 11/08/16, 11:58
DatabaseCharsetUpdate.php:99