Review main Merged

50534[TASK] Replace beginsWith method with strpos to reduce execution time

Wouter Wolters CR +2 V +2 Normal +56 −87 updated 11/08/16, 11:58

Commit message

Use the native PHP method strpos instead of StringUtility::beginsWith
method. The beginsWith method runtime compared to a simple strpos check
is much higher.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 33

Show 13 more files

Review log 1216

  1. Wouter Wolters uploaded patch set 1 11/07/16, 20:25

  2. TYPO3com voted on patch set 1 V -1 11/07/16, 20:29 Completed build in 04m 31s on Mon, 7 Nov, 09:29 PM Test Summary: 55235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4687

  3. Wouter Wolters uploaded patch set 2 11/07/16, 21:16

  4. TYPO3com voted on patch set 2 V +1 11/07/16, 21:20 Completed build in 03m 49s on Mon, 7 Nov, 10:20 PM Test Summary: 55235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4691

  5. Wouter Wolters updated the commit message in patch set 3 11/07/16, 21:27

  6. TYPO3com voted on patch set 3 V +1 11/07/16, 21:31 Completed build in 03m 42s on Mon, 7 Nov, 10:31 PM Test Summary: 55235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4693

  7. Susi Moog voted on patch set 3 CR +1 11/08/16, 09:09

  8. Christian Kuhn commented on patch set 3 CR -1 11/08/16, 09:52

    DatabaseCharsetUpdate.php:99

    typo strpoC
  9. Markus Klein commented on patch set 3 11/08/16, 10:12

    Are you sure it is safe to change that everywhere? beginsWith() does way more than just comparing strings!
  10. Markus Klein uploaded patch set 4 11/08/16, 10:25

  11. Markus Klein commented on patch set 4 CR +1 V +1 11/08/16, 10:27

    Works as far as I tested. All conversions should be correct, I hope I didn't overlook a mistake.
  12. TYPO3com voted on patch set 4 V +1 11/08/16, 10:32 Completed build in 06m 43s on Tue, 8 Nov, 11:32 AM Test Summary: 55247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4700

  13. Wouter Wolters commented on patch set 4 11/08/16, 10:43

    @markus I did not replace this automatically but had a close look in every situation. AFAICS there shouldn't be a problem but I suggest to have some more eyes on this one here.
  14. Frank Nägler voted on patch set 4 CR +1 11/08/16, 11:22

  15. Frank Nägler voted on patch set 4 CR +2 V +2 11/08/16, 11:58

  16. Gerrit merged patch set 4 11/08/16, 11:58