Review main Merged

50549[TASK] Use a cast to float instead of doubleval

Wouter Wolters CR +2 V +2 Normal +30 −30 updated 11/09/16, 21:54

Commit message

The method doubleval is an alias of floatval and
this could be used. But using a cast to float is
quicker.

Review

  • Code review CR +2
    • Benni Mack +2
    • Jörg Bösche +1
  • Verified V +2
    • Benni Mack +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1420

  1. Wouter Wolters uploaded patch set 1 11/08/16, 22:15

  2. Andreas Kienast commented on patch set 1 11/08/16, 22:20

    SpellCheckingController.php:182

    Can't we directly use 0.5 here? `floatval($AspellVersion) < 0.5`
  3. TYPO3com voted on patch set 1 V +1 11/08/16, 22:20 Completed build in 05m 36s on Tue, 8 Nov, 11:20 PM Test Summary: 55247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4719

  4. Wouter Wolters uploaded patch set 2 11/08/16, 22:26

  5. TYPO3com voted on patch set 2 V +1 11/08/16, 22:31 Completed build in 05m 04s on Tue, 8 Nov, 11:31 PM Test Summary: 55247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4720

  6. Wouter Wolters uploaded patch set 3 11/08/16, 22:38

  7. Wouter Wolters uploaded patch set 4 11/08/16, 22:39

  8. TYPO3com voted on patch set 3 V +1 11/08/16, 22:44 Completed build in 05m 58s on Tue, 8 Nov, 11:44 PM Test Summary: 55247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4721

  9. TYPO3com voted on patch set 4 V +1 11/08/16, 22:48 Completed build in 08m 51s on Tue, 8 Nov, 11:48 PM Test Summary: 55247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4722

  10. Benni Mack voted on patch set 4 CR +1 11/09/16, 13:06

  11. Michael Oehlhof commented on patch set 4 CR +1 V +1 11/09/16, 14:00

    Verified by running unit tests and check if all occurrences of doubleval() are captured by this patch.

    ClientUtility.php:172

    getting floatval() of => getting float value of
  12. Frank Nägler commented on patch set 5 11/09/16, 15:20

    Published edit on patch set 4.
  13. Frank Nägler commented on patch set 5 CR +2 V +2 11/09/16, 15:21

    great patch, I had some special moment while review this patch :D
  14. TYPO3com voted on patch set 5 V +1 11/09/16, 15:25 Completed build in 05m 07s on Wed, 9 Nov, 04:25 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4731

  15. Wouter Wolters commented on patch set 5 CR -1 11/09/16, 15:29

    will add a few more floatval() to (float)
  16. Wouter Wolters uploaded patch set 6 11/09/16, 15:37

  17. TYPO3com voted on patch set 6 V +1 11/09/16, 15:42 Completed build in 04m 54s on Wed, 9 Nov, 04:42 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4732

  18. Jörg Bösche commented on patch set 6 CR +1 V +1 11/09/16, 18:30

    Unit test suite is green! Partial test of the progressbar in the scheduler was successful! Good job!
  19. Benni Mack voted on patch set 6 CR +2 V +2 11/09/16, 21:54

  20. Gerrit merged patch set 6 11/09/16, 21:54