Review main Merged

50553[TASK] Streamline and optimize JavaScript in install tool

Frank Nägler CR +2 V +2 Hard +142 −119 updated 11/11/16, 22:47

Commit message

This patch optimize and streamline the JavaScript of Install.js
The following changes are part of the patch:

- Centralized FlashMessage handling
- Streamline server side and browser side severities
- Optimize performance, remove duplicate jQuery selector
- Remove console.debug calls
- Remove unused FlashMessage templates from views

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 913

  1. Frank Nägler uploaded patch set 1 11/09/16, 13:04

  2. TYPO3com voted on patch set 1 V -1 11/09/16, 13:11 Completed build in 06m 24s on Wed, 9 Nov, 02:11 PM Test Summary: 6 of 55247 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4724

  3. Frank Nägler uploaded patch set 2 11/09/16, 13:30

  4. TYPO3com voted on patch set 2 V +1 11/09/16, 13:35 Completed build in 05m 14s on Wed, 9 Nov, 02:35 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4725

  5. Wouter Wolters commented on patch set 2 11/09/16, 15:20

    JsonView.php:84

    phpdoc missing
  6. Frank Nägler uploaded patch set 3 11/11/16, 17:41

  7. TYPO3com voted on patch set 3 V -1 11/11/16, 17:46 Completed build in 05m 19s on Fri, 11 Nov, 06:46 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4825

  8. Frank Nägler uploaded patch set 4 11/11/16, 17:58

  9. TYPO3com voted on patch set 4 V +1 11/11/16, 18:03 Completed build in 05m 11s on Fri, 11 Nov, 07:03 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4827

  10. Wouter Wolters voted on patch set 4 CR +1 V +1 11/11/16, 19:05

  11. Markus Klein voted on patch set 4 CR +1 11/11/16, 22:40

  12. Markus Klein voted on patch set 4 CR +2 V +2 11/11/16, 22:47

  13. Gerrit merged patch set 4 11/11/16, 22:47