Review main Merged Breaking

50560[!!!][BUGFIX] Allow override of page creation wizard again

Benni Mack CR +2 V +2 Normal +60 −10 updated 12/18/16, 10:39

Commit message

The TSconfig option to override the page creation wizard via
`mod.web_list.newPageWiz.overrideWithExtension` is impossible
to use anymore since TYPO3 v8, due to the limitation
of the entry-scripts which are only allowed to be in typo3/index.php
for the backend. The option `mod.newPageWizard.override` was
introduced to register a custom route / module to be linked when
adding new pages.

Review

  • Code review CR +2
    • Susi Moog +2
    • Anja Leichsenring +1
  • Verified V +2
    • Susi Moog +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1319

  1. Benni Mack uploaded patch set 1 11/09/16, 21:51

  2. TYPO3com voted on patch set 1 V -1 11/09/16, 21:57 Completed build in 06m 14s on Wed, 9 Nov, 10:57 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4745

  3. Wouter Wolters commented on patch set 1 11/10/16, 14:48

    Breaking-78549-OverridePagePositionMapWizardViaPageTSconfig.rst:4

    issue and includes missing here

    Breaking-78549-OverridePagePositionMapWizardViaPageTSconfig.rst:43

    keyword(s) missing here
  4. Benni Mack uploaded patch set 2 11/12/16, 23:45

  5. TYPO3com voted on patch set 2 V -1 11/13/16, 00:14 Completed build in 29m 22s on Sun, 13 Nov, 01:14 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4875

  6. Benni Mack commented on patch set 3 11/13/16, 08:46

    Published edit on patch set 2.
  7. TYPO3com voted on patch set 3 V -1 11/13/16, 08:57 Completed build in 10m 53s on Sun, 13 Nov, 09:57 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4878

  8. Wouter Wolters uploaded patch set 4 11/13/16, 12:57

  9. TYPO3com voted on patch set 4 V +1 11/13/16, 14:07 Completed build in 1h 10m 09s on Sun, 13 Nov, 03:07 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4891

  10. Michael Oehlhof commented on patch set 5 11/25/16, 17:38

    Published edit on patch set 4.
  11. TYPO3com voted on patch set 5 V +1 11/25/16, 17:43 Completed build in 04m 23s on Fri, 25 Nov, 06:43 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5128

  12. Susi Moog voted on patch set 5 CR +1 12/03/16, 18:13

  13. Susi Moog uploaded patch set 6 12/04/16, 08:44

  14. Anja Leichsenring voted on patch set 6 CR +1 V +1 12/04/16, 08:47

  15. TYPO3com voted on patch set 6 V +1 12/04/16, 08:49 Completed build in 04m 58s on Sun, 4 Dec, 09:49 AM Test Summary: 54298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5443

  16. Susi Moog voted on patch set 6 CR +2 V +2 12/04/16, 08:56

  17. Gerrit merged patch set 6 12/04/16, 08:56

  18. Mathias Schreiber commented on patch set 7 12/17/16, 14:48

    I might be mistaken, but I think this one misses a Feature rst file, correct?
  19. Susi Moog commented on patch set 7 12/18/16, 10:39

    Not really, as the feature itself was there before, then we broke it, now we fixed it.