Review main Merged

50575[BUGFIX] Re-enable "default" option in Fluid Case ViewHelper

Benni Mack CR +2 V +2 Easy +1 −1 updated 11/10/16, 17:59

Commit message

A bug, introduced with the registerArguments option does
not work properly anymore with the "default" option for the <f:case>
viewhelper.

Casting the argument let's the option be evaluated again.

Review

  • Code review CR +2
    • Markus Klein +2
    • Claus Due +1
    • Benjamin Kott +1
  • Verified V +2
    • Markus Klein +2
    • Benjamin Kott +1

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 11/10/16, 12:26

  2. Claus Due voted on patch set 1 CR +1 11/10/16, 12:28

  3. Benjamin Kott voted on patch set 1 CR +1 V +1 11/10/16, 12:37

  4. Markus Klein voted on patch set 1 CR +2 V +2 11/10/16, 12:54

  5. Gerrit merged patch set 1 11/10/16, 12:54

  6. TYPO3com commented on patch set 1 11/10/16, 12:55 Completed build in 29m 19s on Thu, 10 Nov, 01:55 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4769

  7. Frans Saris commented on patch set 2 11/10/16, 17:52

    Shouldn't the fluid API cast the value to bool as the argument is registered as bool?
  8. Claus Due commented on patch set 2 11/10/16, 17:59

    > Shouldn't the fluid API cast the value to bool as the argument is registered as bool? This does happen, but only when the argument value is a boolean expression. When it is not, iirc, the value is inserted directly without checking which type it has or casting it to anything specific. You're welcome to open an issue for fluid standalone so we can investigate/change this, but off the top of my head it this would imply an additional processing step for all arguments of all ViewHelperNodes everywhere, and one time per loop etc. as well, so it could be pretty costly just to achieve (compiled) support to cast input arguments.