Review main Abandoned

50580[BUGFIX] allow zero for pidInList

Tobi Kretschmann CR 0 V 0 Easy +19 −1 updated 11/10/16, 17:43

Commit message

Using the DatabaseQueryProcessor with pidInList = 0 does not result
in a query with "tablename.uid = 0" in the where clause anymore.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 45

  1. Tobi Kretschmann uploaded patch set 1 11/10/16, 17:15

  2. TYPO3com voted on patch set 1 V -1 11/10/16, 17:20 Completed build in 05m 19s on Thu, 10 Nov, 06:20 PM Test Summary: 208 of 55267 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4780

  3. Benni Mack commented on patch set 1 11/10/16, 17:23

    Hey Tobi, can you explain how to prevent doing this via pidInList=0 and table=be_users?
  4. Oliver Hader commented on patch set 1 CR -1 11/10/16, 17:24

    You can already use pidInList = root,1,2,3

    ContentObjectRenderer.php:7793

    Use this...
  5. Oliver Hader abandoned the change 11/10/16, 17:43

    I'm closing this change since the desired functionality is available already. Feel free to re-open the issue or leave a note if you feel, that something is still missing there