Review main Merged

50581[TASK] Remove typo3/.htaccess

Markus Klein CR +2 V +2 Easy +17 −24 updated 11/11/16, 14:18

Commit message

The current solution caused a lot of troubles with server configuration.
To avoid any nasty workarounds we simply create a real entry point again.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Wouter Wolters +1
    • Andreas Kießling +1
    • Nicole Hummel +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2
    • Alexander Opitz +2
    • Nicole Hummel +1
    • Oliver Hader +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1924

  1. Markus Klein uploaded patch set 1 11/10/16, 17:22

  2. TYPO3com voted on patch set 1 V +1 11/10/16, 17:28 Completed build in 05m 12s on Thu, 10 Nov, 06:28 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4781

  3. Markus Klein uploaded patch set 2 11/10/16, 17:42

  4. TYPO3com voted on patch set 2 V +1 11/10/16, 17:48 Completed build in 05m 38s on Thu, 10 Nov, 06:48 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4784

  5. Markus Klein uploaded patch set 3 11/10/16, 17:58

  6. Nicole Hummel voted on patch set 3 CR +1 11/10/16, 18:02

  7. TYPO3com voted on patch set 3 V +1 11/10/16, 18:04 Completed build in 06m 45s on Thu, 10 Nov, 07:04 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4785

  8. Frank Nägler voted on patch set 3 CR +1 11/10/16, 18:26

  9. Frank Nägler voted on patch set 3 V +1 11/10/16, 18:28

  10. Benni Mack commented on patch set 3 CR -1 V -1 11/10/16, 22:30

    I get a ( ! ) Notice: Undefined index: scheme in typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2601
  11. Markus Klein commented on patch set 3 11/10/16, 22:51

    For the record. Those notices are caused by an invalid PHP setup and are not an issue of our code. (as long as we do not striving for notice-less code)
  12. Oliver Hader commented on patch set 3 11/10/16, 22:53

    Well, I have a similar invalid PHP setup then for a couple of years as well... We could add a output buffer handler, modify the error-reporting mode or fix the notices
  13. Benni Mack voted on patch set 3 CR +1 V +1 11/10/16, 23:28

  14. Markus Klein commented on patch set 4 11/10/16, 23:33

    Published edit on patch set 3.
  15. Markus Klein commented on patch set 5 11/10/16, 23:35

    Published edit on patch set 4.
  16. Benni Mack commented on patch set 5 CR +1 V +1 11/10/16, 23:35

    works like a charm, thank you for the extra mile!
  17. Oliver Hader commented on patch set 5 CR +1 V +1 11/10/16, 23:38

    Thx!
  18. Nicole Hummel voted on patch set 5 CR +1 V +1 11/10/16, 23:40

  19. TYPO3com voted on patch set 4 V +1 11/10/16, 23:48 Completed build in 14m 39s on Fri, 11 Nov, 12:48 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4803

  20. TYPO3com voted on patch set 5 V +1 11/10/16, 23:54 Completed build in 19m 47s on Fri, 11 Nov, 12:54 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4804

  21. Wouter Wolters voted on patch set 5 CR +1 11/11/16, 12:11

  22. Andreas Kießling voted on patch set 5 CR +1 11/11/16, 12:37

  23. Alexander Opitz voted on patch set 5 CR +2 V +2 11/11/16, 14:17

  24. Gerrit merged patch set 5 11/11/16, 14:18