Review main Merged

50594[BUGFIX] Compact clear cache button when one item exists

Claus Due CR +2 V +2 Easy +22 −10 updated 11/20/16, 00:23

Commit message

This change makes the clear cache toolbar item dynamically
either render a drop-down as it did before, or render a single
link directly if there is only a single clear cache action.

If any hooks or permissions add additional items the drop-
down is rendered again.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2226

Show 1 earlier messages
  1. Claus Due uploaded patch set 1 11/11/16, 13:51

  1. Claus Due commented on patch set 1 11/11/16, 13:52

    Will follow this up, if merged, with a suggestion to also do https://forge.typo3.org/issues/78655 (local solution is completed)
  2. TYPO3com voted on patch set 1 V +1 11/11/16, 13:56 Completed build in 04m 56s on Fri, 11 Nov, 02:56 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4812

  3. Philipp Gampe voted on patch set 1 CR +1 11/11/16, 14:04

  4. Mattias Nilsson voted on patch set 1 CR +1 V +1 11/11/16, 14:17

  5. Cedric Ziel voted on patch set 1 CR +1 11/11/16, 15:44

  6. Christian Kuhn commented on patch set 1 CR -1 11/11/16, 17:01

    i'm constantly getting with applied patch: "An error occurs An error occurred while clearing the cache. It is likely not all caches were cleared as expected." Apart from that this "breaks" user expectation for the toolbar, since all other toolbar items do have a drop down, and additionally the explaining text is gone. This needs another ux person sign-off, whether we should do that. And the patch does not work for me as advertised: I have 2 items in the list, but still, the drop down is gone.
  7. Christian Kuhn voted on patch set 1 V -1 11/11/16, 17:01

  8. Philipp Gampe commented on patch set 1 CR 0 V -1 11/11/16, 17:11

    Some as Lolli, the anchor-link of the dropdown gets submitted via AJAX and returns a whole backend as response. It does not open the dropdown any more.
  9. Claus Due uploaded patch set 2 11/11/16, 17:44

  10. Claus Due commented on patch set 1 11/11/16, 17:44

    P2 should solve the issue where the link that used to open the drop-down would perform an unexpected AJAX request.
  11. TYPO3com voted on patch set 2 V +1 11/11/16, 17:51 Completed build in 07m 00s on Fri, 11 Nov, 06:51 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4826

  12. Philipp Gampe commented on patch set 2 V -1 11/11/16, 18:02

    Select the wrong action, well debug now However solves the bug from patchset 1.
  13. Claus Due commented on patch set 2 11/11/16, 18:10

    Do you mean the compacted or the expanded links trigger the wrong action?
  14. Philipp Gampe uploaded patch set 3 11/11/16, 18:13

  15. Philipp Gampe commented on patch set 3 CR +1 V +1 11/11/16, 18:15

    Sorry, works fine. The issue I hit was that the pages cache is always added for admin users, not matter what you do (see line 74). At least you can hook into it later at throw the entry away. I enhanced the patch by also changing the icon if you only have one action, to make it less confusing.
  16. TYPO3com voted on patch set 3 V +1 11/11/16, 18:19 Completed build in 06m 03s on Fri, 11 Nov, 07:19 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4829

  17. Claus Due commented on patch set 3 11/11/16, 18:20

    > Sorry, works fine. The issue I hit was that the pages cache is always added for admin users, not matter what you do (see line 74). At least you can hook into it later at throw the entry away. Ah, okay, great! Yes, my next plan was to suggest a patch that makes the only action available in development context, the flush all action. I plan that because recently I saw an entire office of devs clear three individual caches at least 20 times in one day, each. If that doesn't get accepted I plan on making an extension that exactly uses the hooks to manipulate the entries based on context; or perhaps based on a different env or similar.
  18. Stefan Neufeind commented on patch set 3 V -1 11/12/16, 17:40

    imho wrong: it should display the title of the one action ("Flush all caches") instead of the headline for the dropdown ("Clear cache"). imho up to discussion: With a single item shown the description is not shown anymore.
  19. Christian Kuhn commented on patch set 3 11/18/16, 22:26

    had a small chat with felix kopp an that one (from ux point of view). first reaction was "yes, do that, maybe just have the icon then alike that one that is "fetched up"". thus, i'd be fine with the patch if the technical details are sorted out.
  20. Claus Due commented on patch set 3 11/19/16, 09:08

    Good point about the UX. I'll update this to: * Take the link title from the link that is compacted into the button * Replace the icon with the one from the compacted link
  21. Claus Due uploaded patch set 4 11/19/16, 10:48

  22. TYPO3com voted on patch set 4 V +1 11/19/16, 10:52 Completed build in 04m 04s on Sat, 19 Nov, 11:52 AM Test Summary: 55307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5012

  23. Philipp Gampe voted on patch set 4 CR +1 V +1 11/19/16, 12:04

  24. Christian Kuhn voted on patch set 4 CR +2 V +2 11/20/16, 00:23

  25. Gerrit merged patch set 4 11/20/16, 00:23