Review main Merged

50596[TASK] Initialize BackendUser options in constructor

Benni Mack CR +2 V +2 Easy +6 −7 updated 11/19/16, 23:54

Commit message

Instead of calling / setting properties from the outside, the backend
user constructor can set options like lockIP centralized.

This way, certain implementations from third-party extensions
can just instantiate the object.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Benni Mack uploaded patch set 1 11/11/16, 15:26

  2. TYPO3com voted on patch set 1 V +1 11/11/16, 15:32 Completed build in 06m 07s on Fri, 11 Nov, 04:32 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4816

  3. Wouter Wolters voted on patch set 1 CR +1 11/11/16, 17:07

  4. Jörg Bösche voted on patch set 1 CR +1 11/12/16, 23:46

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 11/18/16, 22:24

  6. Jörg Bösche voted on patch set 1 V +1 11/19/16, 22:46

  7. Christian Kuhn commented on patch set 1 CR +2 V +2 11/19/16, 23:54

    cool. thx for adding missing testing vote, Joerg!
  8. Gerrit merged patch set 1 11/19/16, 23:54